Intermittent LeakSanitizer | leak at mozilla::detail::UniqueSelector, operator=, mozilla::dom::ClientInfo::ClientInfo, emplace
Categories
(Core :: Networking: WebSockets, defect, P2)
Tracking
()
People
(Reporter: intermittent-bug-filer, Assigned: valentin)
References
(Blocks 1 open bug)
Details
(Keywords: intermittent-failure, Whiteboard: [necko-triaged], [wptsync upstream][stockwell fixed:patch])
Attachments
(3 files)
Filed by: rgurzau [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=276068681&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/SoOnLUWlTrelso0iegzLHQ/runs/0/artifacts/public/logs/live_backing.log
[task 2019-11-13T21:23:15.210Z] 21:23:15 INFO - TEST-START | /websockets/remove-own-iframe-during-onerror.window.html
[task 2019-11-13T21:23:15.214Z] 21:23:15 INFO - Closing window 353
[task 2019-11-13T21:23:15.316Z] 21:23:15 INFO - PID 6173 | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2019-11-13T21:23:15.635Z] 21:23:15 INFO - PID 6173 | =================================================================
[task 2019-11-13T21:23:15.635Z] 21:23:15 INFO - PID 6173 | LeakSanitizer: detected memory leaks
[task 2019-11-13T21:23:15.636Z] 21:23:15 INFO - PID 6173 | Indirect leak of 1824 byte(s) in 3 object(s) allocated from:
task 2019-11-13T21:23:21.552Z] 21:23:21 INFO - PID 6173 | Suppressions used:
[task 2019-11-13T21:23:21.552Z] 21:23:21 INFO - PID 6173 | count bytes template
[task 2019-11-13T21:23:21.552Z] 21:23:21 INFO - PID 6173 | 24 728 nsComponentManagerImpl
[task 2019-11-13T21:23:21.553Z] 21:23:21 INFO - PID 6173 | 4 832 mozJSComponentLoader::LoadModule
[task 2019-11-13T21:23:21.553Z] 21:23:21 INFO - PID 6173 | 611 17509 libfontconfig.so
[task 2019-11-13T21:23:21.553Z] 21:23:21 INFO - PID 6173 | 1 29 libglib-2.0.so
[task 2019-11-13T21:23:21.554Z] 21:23:21 INFO - PID 6173 | -----------------------------------------------------
[task 2019-11-13T21:23:21.662Z] 21:23:21 INFO - Browser exited with return code 0
[task 2019-11-13T21:23:21.663Z] 21:23:21 INFO - PROCESS LEAKS None
[task 2019-11-13T21:23:21.663Z] 21:23:21 INFO - ERROR | LeakSanitizer | SUMMARY: AddressSanitizer: 13248 byte(s) leaked in 80 allocation(s).
[task 2019-11-13T21:23:21.664Z] 21:23:21 INFO - LeakSanitizer | To show the addresses of leaked objects add report_objects=1 to LSAN_OPTIONS
[task 2019-11-13T21:23:21.664Z] 21:23:21 INFO - This can be done in testing/mozbase/mozrunner/mozrunner/utils.py
[task 2019-11-13T21:23:21.665Z] 21:23:21 INFO - Allowed depth was 4
[task 2019-11-13T21:23:21.665Z] 21:23:21 INFO - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at mozilla::detail::UniqueSelector, operator=, mozilla::dom::ClientInfo::ClientInfo, emplace
[task 2019-11-13T21:23:21.666Z] 21:23:21 INFO - TEST-FAIL | LeakSanitizer | leak at Alloc, nsTSubstring, nsTSubstring, nsTSubstring
[task 2019-11-13T21:23:21.666Z] 21:23:21 INFO - INFO | LeakSanitizer | Frame Alloc matched a expected leak
[task 2019-11-13T21:23:21.667Z] 21:23:21 INFO - TEST-FAIL | LeakSanitizer | leak at mozilla::dom::WebSocket::WebSocket, mozilla::dom::WebSocket::ConstructorCommon, mozilla::dom::WebSocket::Constructor, mozilla::dom::WebSocket_Binding::_constructor
[task 2019-11-13T21:23:21.667Z] 21:23:21 INFO - INFO | LeakSanitizer | Frame mozilla::dom::WebSocket::WebSocket matched a expected leak
Assignee | ||
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 3•5 years ago
|
||
(In reply to Razvan Maries from comment #1)
The bug seems to happen because of this line in the WPT harness
line = 'cors = ' + cors + ' | cookie = ' + cookie.value;
This in turn probably fails because the expected cookie isn't there, but it still shouldn't throw.
It's probably the fact that the test doesn't complete that's keeping WS alive and causing the leak. I'll write up a quick patch and we'll see if that fixes things.
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 5•5 years ago
|
||
cookie.value can't be accessed when cookie.first defaults to "no" which causes
it to throw an exception.
This change makes it so we only access cookie.value when the cookie.first
actually returns a cookie.
Assignee | ||
Comment 6•5 years ago
|
||
(In reply to Stefan Hindli [:stefan_hindli] from bug 159625 comment #7)
(In reply to Mathew Hodson from bug 159625 comment #8)
It looks like the commit message for this had the wrong bug ID.
(In reply to Web Platform Test Sync Bot (IRC #interop) from bug 159625 comment #5)
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20280 for changes under testing/web-platform/tests
Assignee | ||
Comment 7•5 years ago
|
||
This exception is unlikely to be the cause of the leak in bug 1596251, but I
came across it while investigating.
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•5 years ago
|
Comment 12•5 years ago
|
||
bugherder |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•5 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment 18•5 years ago
|
||
jmaher, valentin, i suspect this is still happening. Could you, please, take a look?
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 20•5 years ago
|
||
Assignee | ||
Comment 21•5 years ago
|
||
Unfortunately I was unable to fix the underlying problem. We have a bunch of resources that leak via websockets. I suspect they aren't being cleaned up properly. We are tracking several other leaks in bug 1582481 - and we'll eventually need to develop a proper fix.
In the mean time the attached patch adds ClientInfo to the allow-list for WPT, which should reduce the orange tint of the trees.
Updated•5 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment 23•5 years ago
|
||
Updated•5 years ago
|
Comment 24•5 years ago
|
||
bugherder |
Comment hidden (Intermittent Failures Robot) |
Comment 26•5 years ago
|
||
No failures since the 25th of November.
Assignee | ||
Updated•5 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Description
•