Remove XUL special-case code from CSS Grid layout
Categories
(Core :: Layout: Grid, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: dholbert, Assigned: emilio)
References
Details
Attachments
(4 files)
In bug 1593060, I'm planning on adding some special case code for CSS grid items that happen to be XUL content (for some cases where we're swapping in CSS grid in our still-mostly-XUL-for-now Firefox frontend code).
I'm filing this followup to remove that special case once it's no longer needed (i.e. once we've removed all XUL frontend code, or at least all XUL elements that are CSS grid items).
|
Reporter | |
Updated•5 years ago
|
|
||
Comment 1•5 years ago
|
||
With bug 1606130 which seems to be solving a number of issues, I made a try push with the special case backed out: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b90dc1bb4e04f0ddc043d09645d35bb833ff06b to check whether the workaround is still needed.
Bugs to test: bug 1603397, bug 1593060, potentially other XUL layout removal/dialog related bugs
|
|
||
Comment 2•5 years ago
|
||
Bug 1606130 doesn't solve bug 1593060, so the special case can't be backed out atm :)
|
||
Comment 3•4 years ago
|
||
Does bug 1525737 remove all the XUL grid use cases in front-end code that the special case in grid container can be removed?
|
|
Reporter | |
Comment 4•4 years ago
|
||
This bug is orthogonal to bug 1525737, I think.
It looks like bug 1525737 removed XUL grid, but that doesn't make this bug actionable. This bug has to do with a special-case for XUL content inside of a CSS grid (which is a scenario that became more common as we removed XUL grid, since the straightforward migration path was to replace the XUL grid with a CSS grid)
So: this bug isn't actionable until we have zero cases of XUL content inside of a CSS grid. We could discover whether that's the case by e.g. adding a fatal assert inside the IsXULBoxFrame()-guarded chunk of https://phabricator.services.mozilla.com/D54886, and seeing if that assert fires during tests & a thorough exercising of our UI.
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
|
Assignee | |
Comment 5•2 years ago
|
||
We have no more grid items being XUL boxes.
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 6•2 years ago
|
||
Just minor nit I noticed while going through the code.
Depends on D172873
|
|
Assignee | |
Comment 7•2 years ago
|
||
The only XUL frames that remain are either scrollbars, or leafs. These are uses
that I'm pretty sure are no longer needed. There are a few others that will go
in the future.
Depends on D172874
|
|
Assignee | |
Comment 8•2 years ago
|
||
We no longer have any use of it.
Depends on D172875
|
|
Assignee | |
Updated•2 years ago
|
|
||
Comment 10•2 years ago
|
||
|
||
Comment 11•2 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•2 years ago
|
|
|
||
Comment 12•2 years ago
|
||
|
|
||
Comment 13•2 years ago
|
||
| bugherder | ||
Description
•