Mechanically remove useless inclusions of header files generated from IDL templates
Categories
(Core :: General, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: gsvelto, Assigned: gsvelto)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
As per the title. I made a crude script to remove as many useless inclusions as possible and patched up the rest by hand.
|
Assignee | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
Can't attach my patch because our Phabricator instance rejects it as too large... I'll have to split it out in multiple parts.
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D55442
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D55443
|
|
Assignee | |
Comment 5•5 years ago
|
||
I fixed up a bunch of breakage that crept in during the rebases and I'm running a last try run. If it turns out green I'll land this right away; down with the useless inclusions!
|
||
Comment 7•5 years ago
|
||
Backed out changeset f6e53d1c6518 (bug 1600545) for Android build bustage. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279579455&repo=autoland&lineNumber=14837
Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=f6e53d1c65182d92d51f94caec7bacea5be729f6
Backout:
https://hg.mozilla.org/integration/autoland/rev/04da0ed7b980ff65c4c081772ce5737080b72dca
|
|
Assignee | |
Comment 8•5 years ago
|
||
This is odd, I didn't encounter this issue locally nor in my try builds. I'll investigate a bit further before relanding.
|
|
Assignee | |
Comment 9•5 years ago
|
||
What's even stranger is that most build failures seem to be caused by missing the nsIXPConnectWrappedJS definition in toolkit/components/sessionstore/SessionStoreListener.cpp, however my patch was explicitly include nsIXPConnect.h in that file. Maybe lando mis-merged something before actually landing? The log only shows the first patch being landed (the one containing the changes to the files under dom/) so it's even odder.
|
|
Assignee | |
Comment 10•5 years ago
|
||
OK, now I get it. If I build with only the first patch applied the build breaks, that's why. I always tested with all three patches or none. Fixing it now.
|
||
Comment 11•5 years ago
|
||
|
||
Comment 12•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d235a06ca6be
https://hg.mozilla.org/mozilla-central/rev/73820a049c64
https://hg.mozilla.org/mozilla-central/rev/1f438b01c780
|
||
Comment 13•5 years ago
|
||
This caused some comm-central breakage. Looks like this: https://hg.mozilla.org/try/rev/4c97a9896dae515dd254d3c9b3240af53099ef00 helps.
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=ed6f5f34c520d586059e7ed1080a53f036a5a867
|
|
||
Comment 14•5 years ago
|
||
|
|
||
Comment 15•5 years ago
|
||
|
|
Assignee | |
Comment 16•5 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #13)
This caused some comm-central breakage. Looks like this: https://hg.mozilla.org/try/rev/4c97a9896dae515dd254d3c9b3240af53099ef00 helps.
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=ed6f5f34c520d586059e7ed1080a53f036a5a867
Sorry for the breakage.
|
|
||
Comment 17•5 years ago
|
||
No worries. We thought we had fixed the Thunderbird build process so it wouldn't run into problems with missing includes, but apparently there is still work to do there.
|
||
Comment 18•5 years ago
|
||
| bugherder | ||
|
||
Comment 19•5 years ago
|
||
FYI, that patch is a solution, but may not be the ideal solution. (I wrote it.) I just blindly put back some lines where they were removed, but I suspect they should be elsewhere, and possibly including something other than nsIDocShell.h. You may want to follow up.
| Comment hidden (Intermittent Failures Robot) |
Description
•