Focus on reply should be in message body, is in To field instead
Categories
(Thunderbird :: Message Compose Window, defect)
Tracking
(Not tracked)
People
(Reporter: jik, Assigned: aleca)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
|
(deleted),
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
image/png
|
Details |
removeTo.png
This is a regression caused by the changes for bug 440377 that landed earlier today.
When I reply to a message my keyboard focus should start in the message body, but instead it's in the To field.
|
Reporter | |
Updated•5 years ago
|
|
|
Reporter | |
Updated•5 years ago
|
|
Assignee | |
Comment 1•5 years ago
|
||
Thanks for reporting this, it's extremely helpful having as much feedback as possible on this early implementation that just landed.
Confirmed. I'll take care of it.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
This should fix it.
|
||
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
You're right, that value will always be empty.
I tweaked it a bit to not use closest(), since the container we need has its own ID.
|
|
Assignee | |
Updated•5 years ago
|
|
|
||
Comment 6•5 years ago
|
||
Try run?
|
|
Assignee | |
Comment 7•5 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #6)
Try run?
Agh, sorry, I completely forgot about it:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=6026e1f4c9b7f54e34ef01e5998909bd8c351382
It hasn't finished yet, let's see if something unusual pops up.
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/08af3c83117b
Fix focus on message body when compose window is opened by a reply action. r=mkmelin
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 10•5 years ago
|
||
(In reply to Pulsebot from comment #8)
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/08af3c83117b
Fix focus on message body when compose window is opened by a reply action. r=mkmelin
This fixed the problem in Mail, but does NOT fix the same Problem when you answer a newsgroup-posting!
And BTW: the To-Field is superfluous in Newsgroups and should not be shown.
|
||
Comment 11•5 years ago
|
||
(In reply to ruediger.lahl from comment #10)
(In reply to Pulsebot from comment #8)
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/08af3c83117b
Fix focus on message body when compose window is opened by a reply action. r=mkmelinThis fixed the problem in Mail, but does NOT fix the same Problem when you answer a newsgroup-posting!
And BTW: the To-Field is superfluous in Newsgroups and should not be shown.
Still happening in Thunderbird 73.0b1 also with newsgroup followups.
|
|
||
Comment 12•5 years ago
|
||
(In reply to WaltS48 [:walts48] from comment #11)
(In reply to ruediger.lahl from comment #10)
(In reply to Pulsebot from comment #8)
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/08af3c83117b
Fix focus on message body when compose window is opened by a reply action. r=mkmelinThis fixed the problem in Mail, but does NOT fix the same Problem when you answer a newsgroup-posting!
And BTW: the To-Field is superfluous in Newsgroups and should not be shown.Still happening in Thunderbird 73.0b1 also with newsgroup followups.
And of course in 74.01a Dailys.
|
|
||
Comment 13•5 years ago
|
||
Image showing the To: field in a newsgroup composition window.
|
|
Assignee | |
Comment 14•5 years ago
|
||
We're taking care of this in bug 1607526.
I'll take a look at why the focus doesn't work with newsgroups.
|
|
||
Comment 15•5 years ago
|
||
Thanks! I'll close this one again.
Description
•