Closed Bug 1605410 Opened 5 years ago Closed 5 years ago

Port bug 1570499: Replace MOZ_FALLTHROUGH macro with C++17's [[fallthrough]] attribute

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 73.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

No description provided.
Attached patch 1605410-MOZ_FALLTHROUGH.patch (deleted) — Splinter Review

Replaced every MOZ_FALLTHROUGH through [[fallthrough]] like in https://hg.mozilla.org/mozilla-central/rev/68b0f6bd38ad89654bde1da2f3755597f6807a43

I'm still building.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9117284 - Flags: review?(mkmelin+mozilla)

Build finished. So patch should be good.

Comment on attachment 9117284 [details] [diff] [review] 1605410-MOZ_FALLTHROUGH.patch Review of attachment 9117284 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. If only all bustage was this clean :-)
Attachment #9117284 - Flags: review+
Attachment #9117284 - Flags: review?(mkmelin+mozilla)

Pushed by richard.marti@gmail.com:
https://hg.mozilla.org/comm-central/rev/c328fb103d47
Port bug 1570499: Replace MOZ_FALLTHROUGH macro with C++17's [[fallthrough]] attribute. r=bcampell

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 73.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: