Android paths are generated with Windows file separators
Categories
(Testing :: geckodriver, defect, P3)
Tracking
(firefox74 fixed)
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: barret, Assigned: barret)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
When running Geckodriver on Windows, it will generate paths for the Android device that use the Windows file separator, e.g.:
/data/local/tmp\org.mozilla.geckoview_example-geckoview-config.yaml
This results in operations that will fail.
|
||
Comment 1•5 years ago
|
||
Thanks for filing! We should indeed fix that for the 0.27 release.
The failing part is here:
https://searchfox.org/mozilla-central/rev/9b4b41b95cbcda63f565bdc24411e15248f91d83/testing/geckodriver/src/android.rs#256-257
Given that push() doesn't offer a custom path separator I would propose we combine those two lines, and directly create the path buf.
Barret, would you be interested to fix that?
|
||
Updated•5 years ago
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
I'll do that for now, but I think mozdevice should not be accepting a Path for remote paths, since Path is only valid for local paths. I'm going to file a bug to update mozdevice to use nix::NixPath or similar (or &str)
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
Paths for pushing files to Android devices were being constructed with
PathBuf::push, which uses the system file separator. On Windows, this results
in malformed paths like
/data/local/tmp\org.mozilla.geckoview_example-geckoview-config.yml.
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Description
•