Closed Bug 1609958 Opened 5 years ago Closed 5 years ago

Cursor not visible upon first edit of recipient pill

Categories

(Thunderbird :: Message Compose Window, defect, P1)

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 74.0

People

(Reporter: thomas8, Assigned: aleca)

References

Details

Attachments

(1 file)

STR

  1. New message, type |John Doe <john@asdf.com>| as recipient (sic; must be longer than edit-pill default length), press Enter -> creates new pill.
  2. cursor left to select virgin pill, press Enter to edit

Actual

  • cursor not visible (but functional, at the end of label; note that the bug does not occur if your recipient is too short)
  • starting from 2nd edit, cursor always visible

Expected

  • cursor should be visible also on first edit of a pill

Notes
My display settings on Windows have 140% screen scaling, which may change font sizes.

Summary: Cursor not visible upon first edit of pill → Cursor not visible upon first edit of recipient pill
Assignee: nobody → alessandro
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → Thunderbird 74.0
Version: 73 → Trunk
Attached patch 1609958-edit-pill-size.patch (deleted) — Splinter Review

Thanks for identifying this.
The issue was a tiny shift of 1px in the padding of the pill.
I solved it by removing the inline margin of the label and keeping the padding consistent for each state (editing and non-editing).

Attachment #9123731 - Flags: ui-review?(richard.marti)
Attachment #9123731 - Flags: review?(mkmelin+mozilla)
Attachment #9123731 - Flags: feedback?(bugzilla2007)
Comment on attachment 9123731 [details] [diff] [review] 1609958-edit-pill-size.patch This works, thanks!
Attachment #9123731 - Flags: ui-review?(richard.marti) → ui-review+
Attachment #9123731 - Flags: review?(mkmelin+mozilla) → review+

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/f7b29a032c0c
Fix the inline padding of the editable recipient pill to not hide the input field cursor. r=mkmelin, ui-r=Paenblab

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Attachment #9123731 - Flags: feedback?(bugzilla2007)

Unfortunately, this is still happening (again), exactly as described in comment 0:
seen on 76.0a1 (2020-03-29) (64-bit)

  • type: |John Doe <john@asdf.com>|, press Enter
  • then cursor left, Enter to re-edit.
    --> editing cursor on the right (after .com) not visible
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

You already opened bug 1627451, there's not need to reopen this as this fix was correct and took care of the issue.
The new issue is a regression caused by something else.

Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Component: Composition → Message Compose Window
Product: MailNews Core → Thunderbird
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: