Cursor not visible upon first edit of recipient pill
Categories
(Thunderbird :: Message Compose Window, defect, P1)
Tracking
(Not tracked)
People
(Reporter: thomas8, Assigned: aleca)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mkmelin
:
review+
Paenglab
:
ui-review+
|
Details | Diff | Splinter Review |
STR
- New message, type |John Doe <john@asdf.com>| as recipient (sic; must be longer than edit-pill default length), press Enter -> creates new pill.
- cursor left to select virgin pill, press Enter to edit
Actual
- cursor not visible (but functional, at the end of label; note that the bug does not occur if your recipient is too short)
- starting from 2nd edit, cursor always visible
Expected
- cursor should be visible also on first edit of a pill
Notes
My display settings on Windows have 140% screen scaling, which may change font sizes.
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Thanks for identifying this.
The issue was a tiny shift of 1px in the padding of the pill.
I solved it by removing the inline margin of the label and keeping the padding consistent for each state (editing and non-editing).
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/f7b29a032c0c
Fix the inline padding of the editable recipient pill to not hide the input field cursor. r=mkmelin, ui-r=Paenblab
Assignee | ||
Updated•5 years ago
|
Reporter | ||
Comment 4•5 years ago
|
||
Unfortunately, this is still happening (again), exactly as described in comment 0:
seen on 76.0a1 (2020-03-29) (64-bit)
- type: |John Doe <john@asdf.com>|, press Enter
- then cursor left, Enter to re-edit.
--> editing cursor on the right (after .com) not visible
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Comment 5•5 years ago
|
||
You already opened bug 1627451, there's not need to reopen this as this fix was correct and took care of the issue.
The new issue is a regression caused by something else.
Assignee | ||
Updated•5 years ago
|
Reporter | ||
Updated•4 years ago
|
Description
•