Closed Bug 1614643 Opened 5 years ago Closed 5 years ago

web-platform-tests have missing manifest information in errorsummary.log

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set
normal

Tracking

(firefox77 fixed)

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: marco, Assigned: ahal)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Assignee: nobody → ahal
Status: NEW → ASSIGNED

This fixes a bug which miscomputes the depth. Say depth=1 and test_path="/Foo/bar.html"
for example.

We then run this line of code:
os.path.sep.join(os.path.dirname(test_path).split(os.path.sep, depth)[:depth])

Breaking it doen a bit:

$ dirname = os.path.dirname("/Foo/bar.html").split(os.path.sep, 1)
$ dirname
["", "Foo"]
$ os.path.sep.join(dirname[:1])
""

According to the specs, --run-by-dir=1 should split tests by the top-level
directory, but it will assign an empty string to everything. Similarly larger
depths will be off by one directory level.

This fixes the issue by stipping the leading separator (and adding it back again
at the end).

This adds "group" information to the 'suite_start' log message. Since WPT don't have
manifests in the same sense that we understand them for other harnesses, we use
directories as stand-ins.

The same algorithm that the 'DirectoryHashChunker' uses to find a directory is used
to determine which level of depth consitutes a "group". This depth is set via
--run-by-dir=<int> in both cases, but will default to leaf directories if not
specified.

Depends on D67625

Attachment #9134673 - Attachment is obsolete: true
Attachment #9134672 - Attachment is obsolete: true
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/370e52ff13b2 [wpt] Log test 'group' information in suite_start, r=jgraham
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/22894 for changes under testing/web-platform/tests
Upstream PR was closed without merging

Please disregard the above message, your patch was backed-out due to an error I've made. I've relanded this one.

Flags: needinfo?(ahal)
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7d6948512ef0 [wpt] Log test 'group' information in suite_start, r=jgraham CLOSED TREE
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: