Closed Bug 1615917 Opened 5 years ago Closed 5 years ago

Allow incremental selection of recipient pills with Ctrl+A

Categories

(Thunderbird :: Message Compose Window, enhancement)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 75.0

People

(Reporter: thomas8, Assigned: thomas8)

References

(Blocks 1 open bug)

Details

(Keywords: access, ux-efficiency, Whiteboard: [relnotetb78][TBKBneeded])

Attachments

(1 file)

We want users to love the new recipient area. So let's add value where we can, and be convenient and efficient like never before. :-)

Libre Office has a nifty feature of incremental selection using Ctrl+A from inside a table cell:
First Ctrl+A selects the current cell, next Ctrl+A selects the entire table, another Ctrl+A selects the entire document. Which makes perfect sense, and is easily applicable to our new recipient area.

First Ctrl+A: Select all pills in the currently focused field (e.g. all pills in To: field).
Next Ctrl+A: Select all pills in the entire recipient area (e.g. all pills in To+CC+BCC).

Wow!!! - oh for the efficiency of that. Delete all recipients in one go, copy, cut - you name it.

For ux-error-prevention, we won't extend the selection when you just hold Ctrl+A a little too long. You may hold Ctrl, but it needs another explicit keypress for the A. No risks, pure fun. Enjoy!

Attached patch incremental-Ctrl+A-pills.diff (deleted) — Splinter Review

Let's do this! :-)

I also improved some comments along the way, querySelectorAll() returns a nodelist, not an array.

Assignee: nobody → bugzilla2007
Status: NEW → ASSIGNED
Attachment #9126983 - Flags: ui-review?(alessandro)
Attachment #9126983 - Flags: review?(alessandro)
Comment on attachment 9126983 [details] [diff] [review] incremental-Ctrl+A-pills.diff Review of attachment 9126983 [details] [diff] [review]: ----------------------------------------------------------------- Nice, this is useful indeed. I'm gonna ask a quick feedback to Magnus just in case he can spot any possible issue, but to me this is r+
Attachment #9126983 - Flags: ui-review?(alessandro)
Attachment #9126983 - Flags: ui-review+
Attachment #9126983 - Flags: review?(alessandro)
Attachment #9126983 - Flags: review+
Attachment #9126983 - Flags: feedback?(mkmelin+mozilla)
Comment on attachment 9126983 [details] [diff] [review] incremental-Ctrl+A-pills.diff Review of attachment 9126983 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/base/content/mailWidgets.js @@ +2570,2 @@ > * > + * @return {Nodelist} Nodelist of all selected <mail-address-pill> elements. NodeList with capital L
Attachment #9126983 - Flags: feedback?(mkmelin+mozilla) → feedback+

I'll fix it before committing.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/c510f2acfb18
Allow incremental selection of recipient pills with Ctrl+A. ui-r=aleca, r=aleca

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 75.0

Awesome. That was quick! Thanks everyone!

My translation engine for Magnus' no-liners said "Cool, clean code, thank you!"

Blocks: 1633562
Blocks: 1602397
No longer depends on: 1602397
Severity: normal → N/A
Component: Composition → Message Compose Window
Product: MailNews Core → Thunderbird

Wayne, I think new keyboard shortcuts should always be included in release notes.
More so for this one because it operates incrementally, which will be a bit hard to discover if not advertised:
Press Ctrl+A once to select all recipients of the same type,
press Ctrl+A again to select all recipients of the message.

Keyboard shortcut Ctrl+A will first select all recipients of the same type, then all message recipients.

Flags: needinfo?(vseerror)
Whiteboard: [relnotetb78]

Rather than calling out individual changes, I think we could accomplish more by having the release notes state that addressing has changed, and then point to a KB article which describes the entire new functionality, including keyboard shortcuts. Someone will need to create said KB article.

Flags: needinfo?(vseerror)
Whiteboard: [relnotetb78] → [relnotetb78][TBKBneeded]
Blocks: 1696692
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: