Closed Bug 1623858 Opened 5 years ago Closed 5 years ago

Document and simplify some Selection related code

Categories

(Core :: DOM: Selection, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: mbrodesser-Igalia, Assigned: mbrodesser-Igalia)

References

(Blocks 1 open bug)

Details

Attachments

(26 files)

(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
No description provided.

It was never read apart from forwarding it to nsFrameSelection.

Depends on D67600

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/84477c862580 part 1) Rename `nsINode::IsSelectionDescendant` to `nsINode::IsMaybeSelected`. r=smaug https://hg.mozilla.org/integration/autoland/rev/fc611a718497 part 2) Declare `nsIContent::HasIndependentSelection` `const`. r=smaug https://hg.mozilla.org/integration/autoland/rev/2caa882e6503 part 3) Remove `TextInputSelectionController::mLimiter`. r=smaug https://hg.mozilla.org/integration/autoland/rev/d03f4d08e7e7 part 4) Document `PresShell::mSelectionFlags`. r=smaug
Keywords: leave-open
Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9c035aabedb4 part 5) Document `nsTextFrame::GetSelectionStatus`. r=smaug
Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5e0d8e21f9f0 part 6) Use `switch` statement in `nsTextPaintStyle::InitSelectionColorsAndShadow`. r=smaug
Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/df14c69672f0 part 7) Rename and simplify `nsFrame::DisplaySelection`. r=smaug
Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8a460e00bd6d part 8) Document `nsIFrame::ComputeSelectionStyle`. r=smaug https://hg.mozilla.org/integration/autoland/rev/70e7b2baa28f part 9) Document more variables corresponding to `nsISelectionController::getDisplaySelection`. r=smaug
Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7e1333796925 part 10) Simplify `Selection::AddRangesForSelectableNodes`'s signature. r=smaug
Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e4ca6d27aa78 part 11) Split `Selection::AddRangesForSelectableNodes`. r=smaug https://hg.mozilla.org/integration/autoland/rev/3067255d5eb2 part 12) Factor determining "selectstart" event target out. r=smaug https://hg.mozilla.org/integration/autoland/rev/0c829e76b0c6 part 13) Declare some methods in `HyperTextAccessible` `const`. r=smaug
Keywords: leave-open
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---

Forgot to update the review on Phabricator.

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d3f2d9592869 part 14) Incorporate feedback of part 12. r=smaug
Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/69539461f67e part 15) Remove some conditions in `nsFrameSelection::TakeFocus` which are always true. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/1aa8cbe35ebb part 16) Annotate `nsFrameSelection::HandleTableSelection` with `[[nodiscard]]`. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/aabd5a62e61c part 17) Assert accessible caret methods in `Selection` are only called for `eNormal` Selections. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/dd3db84e0787 part 18) Assert `Selection::StopAutoScrollTimer` is only called for `eNormal` Selections. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/d2322ca0888a part 19) Remove superfluous `nsAutoScrollTimer::Init`. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/a76c67117050 part 20) Assert `Selection::NotifyAutoCopy` is only called for `eNormal` Selections. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/7e158fb43cad part 21) Add some const correctness to `nsDocumentEncoder::SerializeSelection`. r=hsivonen

Simplifies understanding Selection::NotifySelectionListeners.

Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/13865519a6e9 part 22) Move focusing common editing host to `Selection::StyledRanges`. r=masayuki
Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9033e89239a7 part 23) Factor dispatching `selectstart` event out. r=masayuki https://hg.mozilla.org/integration/autoland/rev/fe77c7e6dda4 part 24) Use local `doc` variable. r=masayuki
Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/96ca51d3b909 part 25) Factor `AreUserSelectedRangesNonEmpty` out. r=masayuki
Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/39c389ff5ce2 part 26) Annotate `MaybeAddRangeAndTruncateOverlaps` with `MOZ_CAN_RUN_SCRIPT`. r=masayuki
Keywords: leave-open
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: