Closed
Bug 162412
Opened 22 years ago
Closed 22 years ago
Merge mi/mtext/ms into a single token class: nsMathMLTokenFrame
Categories
(Core :: MathML, defect)
Core
MathML
Tracking
()
RESOLVED
FIXED
People
(Reporter: rbs, Assigned: rbs)
References
Details
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
rbs
:
review+
rbs
:
superreview+
|
Details | Diff | Splinter Review |
Currently the class hierarchy looks like:
/* <mi> identifier - italics *sometimes*, i.e., context-sensitive */
nsMathMLmiFrame ------------+
|
/* <mtext> vanilla text */ |
nsMathMLmtextFrame ---------+--- nsMathMLContainerFrame --- nsHTMLContainerFrame
|
/* <ms> string which needs to be rendered with generated "quotes" */
nsMathMLmsFrame ------------+
The custom behaviors of each tag is handled by functions in these files. I would
like to merge these files to cut the C++, and use the good old tag test to call
the relevant functions. These are the MathML tags that have child nsTextFrames.
Since text frames are non-MathML, they often require special handling. Merging
will help to centralize the special handling. In particualar, the support of the
|mathvariant| attribute needs special transformation in the text.
Bug 114365 comment 2 describes the full scope of the issues needed to support
this mathvariant attribute. This bug is a sub-task in the chain.
Blocks: mathvariant
Attachment #95056 -
Attachment is obsolete: true
Welcoming reviews at this stage.
Attachment #95058 -
Attachment is obsolete: true
bz/roc, care to review? It is essentially a shuffling of functions. Will be good
to land this early in the milestone ot let it bake a bit.
Comment on attachment 95142 [details] [diff] [review]
iteration to clean those old .get() in the code being moved by the patch
r=roc+moz
usual caveats apply...
Attachment #95142 -
Flags: review+
Comment on attachment 95142 [details] [diff] [review]
iteration to clean those old .get() in the code being moved by the patch
sr=kin@netscape.com
I'm guessing mathml isn't built on Mac since there aren't any mac xml project
diffs, and no project xml files in the mathml dir?
Attachment #95142 -
Flags: superreview+
oops, it is now built by default, after a loooong time... will take care of the
xml project stuff.
Assignee | ||
Comment 10•22 years ago
|
||
Comment on attachment 95635 [details] [diff] [review]
update to sync with recent changes on the trunk and include macbuild diffs
migrating r/sr
Attachment #95635 -
Flags: superreview+
Attachment #95635 -
Flags: review+
Attachment #95142 -
Attachment is obsolete: true
Assignee | ||
Comment 11•22 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•