Closed Bug 1629866 Opened 5 years ago Closed 4 years ago

Store ChildSHistory on the BrowsingContext

Categories

(Core :: DOM: Navigation, defect, P3)

Product:
Core
Component:
DOM: Navigation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla78
Project Flags:
Fission Milestone M6
Tracking Flags:
Tracking Status
firefox78 --- fixed

People

(Reporter: peterv, Assigned: peterv)

References

(Regressed 1 open bug)

Details

Attachments

(2 files)

Bug 1629866 - Store ChildSHistory on the BrowsingContext. r=nika,smaug
(deleted), text/x-phabricator-request
Details
Bug 1629866 - Set the srcdoc to a void string if INTERNAL_LOAD_FLAGS_IS_SRCDOC is set, to appease assertion in DocumentChannelChild::RecvRedirectToRealChannel. r?mattwoodrow!
(deleted), text/x-phabricator-request
Details
No description provided.

Tracking for Fission Nightly milestone (M6)

Severity: -- → normal
Fission Milestone: --- → M6
Attachment #9140688 - Attachment description: Bug 1629866 - Store ChildSHistory on the BrowsingContext → Bug 1629866 - Store ChildSHistory on the BrowsingContext. r?nika!
Attachment #9140688 - Attachment description: Bug 1629866 - Store ChildSHistory on the BrowsingContext. r?nika! → Bug 1629866 - Store ChildSHistory on the BrowsingContext. r=nika/smaug
Attachment #9140688 - Attachment description: Bug 1629866 - Store ChildSHistory on the BrowsingContext. r=nika/smaug → Bug 1629866 - Store ChildSHistory on the BrowsingContext. r=nika,smaug
Pushed by pvanderbeken@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fe2d4790b73a Store ChildSHistory on the BrowsingContext. r=nika,smaug

Backed out for assertion failures on DocumentChannelChild.cpp

backout: https://hg.mozilla.org/integration/autoland/rev/02f46362fdb0c35a8e4dd208f0de70827a75d1a1

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Cquantumrender%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-mochitest-plain-fis-e10s-3%2Cm-fis%283%29&revision=fe2d4790b73a0c404e2516c7c4aa510807fc318f&selectedTaskRun=VYDX3-xhRMOdx7O8vnUvDw-0

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302118532&repo=autoland&lineNumber=3914

[task 2020-05-13T14:52:55.481Z] 14:52:55 INFO - TEST-START | dom/tests/mochitest/bugs/test_navigator_buildID.html
[task 2020-05-13T14:52:55.968Z] 14:52:55 INFO - GECKO(2610) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpowJtbC.mozrunner/runtests_leaks_tab_pid3517.log
[task 2020-05-13T14:52:55.969Z] 14:52:55 INFO - GECKO(2610) | [3517, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp, line 225
[task 2020-05-13T14:52:56.126Z] 14:52:56 INFO - GECKO(2610) | [Child 2947, Main Thread] WARNING: NS_ENSURE_TRUE(request) failed: file /builds/worker/checkouts/gecko/netwerk/base/nsLoadGroup.cpp, line 591
[task 2020-05-13T14:52:56.305Z] 14:52:56 INFO - GECKO(2610) | [Child 3517, Main Thread] WARNING: could not set real-time limit at process startup: file /builds/worker/checkouts/gecko/dom/ipc/ContentChild.cpp, line 1640
[task 2020-05-13T14:52:56.605Z] 14:52:56 INFO - GECKO(2610) | Assertion failure: (aArgs.loadStateLoadFlags() & nsDocShell::InternalLoad::INTERNAL_LOAD_FLAGS_IS_SRCDOC) || aArgs.srcdocData().IsVoid(), at /builds/worker/checkouts/gecko/netwerk/ipc/DocumentChannelChild.cpp:166
[task 2020-05-13T14:52:56.609Z] 14:52:56 INFO - Initializing stack-fixing for the first stack frame, this may take a while...
[task 2020-05-13T14:53:07.979Z] 14:53:07 INFO - GECKO(2610) | #01: mozilla::net::PDocumentChannelChild::OnMessageReceived(IPC::Message const&) [s3:gecko-generated-sources:cf0e0601d88a8493920dfc72e9dc42626ed35c605f40fdef3e134dfc9a2a1f71385d4e2a897c2f552bf86c1149ec623afb80a847d5dbbba93f72f0ecbff15938/ipc/ipdl/PDocumentChannelChild.cpp::271]
[task 2020-05-13T14:53:07.979Z] 14:53:07 INFO - GECKO(2610) | #02: mozilla::dom::PContentChild::OnMessageReceived(IPC::Message const&) [s3:gecko-generated-sources:9936c9f967bf3842890f7f2a831b167d287d5ad815f4df7f962f49625bb0d41220390f983e94d0511cbed909194d98d03280c38cbec99dff4318b06a1eae8835/ipc/ipdl/PContentChild.cpp::8486]
[task 2020-05-13T14:53:07.980Z] 14:53:07 INFO - GECKO(2610) | #03: mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&) [ipc/glue/MessageChannel.cpp:2187]
[task 2020-05-13T14:53:07.980Z] 14:53:07 INFO - GECKO(2610) | #04: mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) [ipc/glue/MessageChannel.cpp:2113]
[task 2020-05-13T14:53:07.980Z] 14:53:07 INFO - GECKO(2610) | #05: mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::MessageChannel::MessageTask&) [ipc/glue/MessageChannel.cpp:0]
[task 2020-05-13T14:53:07.980Z] 14:53:07 INFO - GECKO(2610) | #06: mozilla::ipc::MessageChannel::MessageTask::Run() [ipc/glue/MessageChannel.cpp:1991]
[task 2020-05-13T14:53:07.981Z] 14:53:07 INFO - GECKO(2610) | #07: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:1211]
[task 2020-05-13T14:53:07.981Z] 14:53:07 INFO - GECKO(2610) | #08: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/threads/nsThreadUtils.cpp:501]
[task 2020-05-13T14:53:07.981Z] 14:53:07 INFO - GECKO(2610) | #09: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:0]
[task 2020-05-13T14:53:07.982Z] 14:53:07 INFO - GECKO(2610) | #10: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:315]
[task 2020-05-13T14:53:07.982Z] 14:53:07 INFO - GECKO(2610) | #11: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:291]
[task 2020-05-13T14:53:07.982Z] 14:53:07 INFO - GECKO(2610) | #12: nsBaseAppShell::Run() [widget/nsBaseAppShell.cpp:139]
[task 2020-05-13T14:53:07.982Z] 14:53:07 INFO - GECKO(2610) | #13: XRE_RunAppShell() [toolkit/xre/nsEmbedFunctions.cpp:909]
[task 2020-05-13T14:53:07.983Z] 14:53:07 INFO - GECKO(2610) | #14: mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:237]
[task 2020-05-13T14:53:07.983Z] 14:53:07 INFO - GECKO(2610) | #15: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:315]
[task 2020-05-13T14:53:07.983Z] 14:53:07 INFO - GECKO(2610) | #16: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:291]
[task 2020-05-13T14:53:07.984Z] 14:53:07 INFO - GECKO(2610) | #17: XRE_InitChildProcess(int, char**, XREChildData const*) [toolkit/xre/nsEmbedFunctions.cpp:740]
[task 2020-05-13T14:53:08.048Z] 14:53:08 INFO - GECKO(2610) | #18: content_process_main(mozilla::Bootstrap*, int, char**) [ipc/contentproc/plugin-container.cpp:57]
[task 2020-05-13T14:53:08.048Z] 14:53:08 INFO - GECKO(2610) | #19: main [browser/app/nsBrowserApp.cpp:303]
[task 2020-05-13T14:53:08.049Z] 14:53:08 INFO - fix-stacks error: failed to read breakpad symbols dir /builds/worker/workspace/build/symbols/libc.so.6 for /lib/x86_64-linux-gnu/libc.so.6
[task 2020-05-13T14:53:08.049Z] 14:53:08 INFO - fix-stacks note: this is expected and harmless for system libraries on debug automation runs
[task 2020-05-13T14:53:08.050Z] 14:53:08 INFO - GECKO(2610) | #20: __libc_start_main [/lib/x86_64-linux-gnu/libc.so.6 + 0x21b97]
[task 2020-05-13T14:53:08.050Z] 14:53:08 INFO - GECKO(2610) | #21: ??? [/builds/worker/workspace/build/application/firefox/firefox-bin + 0xfab9]
[task 2020-05-13T14:53:08.051Z] 14:53:08 INFO - GECKO(2610) | #22: ??? (???:???)
[task 2020-05-13T14:53:08.051Z] 14:53:08 INFO - GECKO(2610) | ###!!! [Parent][MessageChannel] Error: (msgtype=0x390133,name=PContent::Msg_CommitBrowsingContextTransaction) Channel error: cannot send/recv

Flags: needinfo?(peterv)

Bug 1598523 added an assertion that if INTERNAL_LOAD_FLAGS_IS_SRCDOC is not set
in a load state's load flags, then the srcdoc must be a void string.
nsDocShell::Reload never set srcdoc to a void string in that case, and wasn't
fixed up.

Pushed by pvanderbeken@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/78efea3a8998 Set the srcdoc to a void string if INTERNAL_LOAD_FLAGS_IS_SRCDOC is set, to appease assertion in DocumentChannelChild::RecvRedirectToRealChannel. r=mattwoodrow https://hg.mozilla.org/integration/autoland/rev/60d5e1d6b152 Store ChildSHistory on the BrowsingContext. r=nika,smaug

https://hg.mozilla.org/mozilla-central/rev/78efea3a8998
https://hg.mozilla.org/mozilla-central/rev/60d5e1d6b152

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox78: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
Flags: needinfo?(peterv)
Regressions: 1634641
Regressions: 1661642
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: