If "Open tabs" suggestion is disabled, top sites in address bar doesn't show open top sites
Categories
(Firefox :: Address Bar, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | verified |
People
(Reporter: yoasif, Assigned: bugzilla)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
8xxnzpbmnpt41.jpg
From: https://www.reddit.com/r/firefox/comments/g42asi/when_disabling_switch_to_tab_feature_on_address/
Steps to reproduce:
- Ensure YouTube is in top sites
- Open YouTube
- Ensure "Open tabs" suggestion is disabled for address bar
- open new tab, navigate to any other site
- Click on address bar
What happens:
YouTube doesn't appear in the top sites suggestions in the address bar.
Expected result:
YouTube appears; clicking the suggestion opens it without switching to existing tab.
|
||
Comment 1•5 years ago
|
||
This is interesting given the use case in the reddit post. However, personally, I'd probably argue that a user who doesn't want open tabs to show up, also doesn't want it to show up if it's a top site.
FWIW, here's the corresponding code: https://searchfox.org/mozilla-central/rev/a4d62e09a4c46aef918667fa759bf9ae898dc258/browser/components/urlbar/UrlbarProviderTopSites.jsm#146
|
||
Comment 2•5 years ago
|
||
We handle it differently, for open tabs we just don't show them as open tabs (provided they are in history or bookmarks), being open doesn't influence frecency.
Based on our current handling this is a bug.
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
|
||
Comment 6•5 years ago
|
||
I verified this issue using Fx 77.0a1 (2020-04-30) on Windows 10 x64 and macOS 10.13.
Description
•