Closed
Bug 1631484
Opened 5 years ago
Closed 5 years ago
Improve bulk operation performance in remote settings by not waiting for the result of each put
Categories
(Firefox :: Remote Settings Client, defect)
Firefox
Remote Settings Client
Tracking
()
RESOLVED
FIXED
Firefox 77
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Florian was looking at a startup profile of some of our mochitests on debug infra.
It seems all these put calls are a bit slow. So I looked around on stackoverflow (where else?) on how to make bulk insertion faster.
The suggestion I saw there was to not wait for each onsuccess event callback, and instead just handle errors and wait for the last one.
In my testing, this reduces the time we spend in the worker for an import of the addons blocklist from about 110ms to about 50ms (on an artifact build on my fast mbp). That seems worth it, especially on slower hardware.
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/faf910a5ca70
make bulk imports / deletes in remote settings faster, r=asuth,leplatrem
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
You need to log in
before you can comment on or make changes to this bug.
Description
•