Remove the remaining uses of nsIAbView and get rid of it
Categories
(MailNews Core :: Address Book, task)
Tracking
(Not tracked)
People
(Reporter: darktrojan, Assigned: darktrojan)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•5 years ago
|
||
In bug 1633620 I ported all but one use of nsAbView to JS. With this I get rid of the remaining use, which was to gather the cards in one or all address books and sort them for printing. I've moved that code in with the printing code.
Throwing away the interface means I can't use tree.view to access the extra functions it provided (because tree.view only gives you an nsITreeView not the real object) but that's okay because we kept a reference to the current view anyway. I had to fix some things to use that reference.
I also discovered some of the functions of nsIAbView are there to support some UI interface stuff that AFAICT has been broken for a long time (and with no bugs complaining about the brokenness) so I've just removed it.
|
||
Comment 2•5 years ago
|
||
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/a8bc54c5c793
Remove the remaining uses of nsIAbView, then remove it and nsAbView. r=mkmelin DONTBUILD
|
|
Assignee | |
Updated•5 years ago
|
Description
•