Closed Bug 1639050 Opened 5 years ago Closed 2 years ago

Enable blocklist v3 on Android on Nightly

Categories

(Toolkit :: Blocklist Implementation, task, P1)

Unspecified
Android
task

Tracking

()

RESOLVED FIXED
114 Branch
Tracking Status
firefox114 --- fixed

People

(Reporter: robwu, Assigned: amejia)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [addons-jira])

Attachments

(1 file)

Bug 1620621 improved the scalability of the addons blocklist. The initial size was small and added to Android in bug 1634671. But if the packaged blocklist were to be updated now, the APK size would increase by 0.5 MB. That's too much, so blocklist v3 will be disabled on mobile at first before enabling the in-tree snapshot of the blocklist (bug 1636158).

Once the size has been optimized, blocklist v3 can be enabled on mobile.

Here is the plan for the size optimization: https://docs.google.com/document/d/1RIOs-7Ud-QlbTOggBydpm47zngT-kWwNzNuFLZTM3iU/edit

Edit: we decided to not implement this optimization. The context and considered options are described at https://docs.google.com/document/d/1tXuykhI6oaL68OKYT0z_qXq9RyHzIlxxeYlxDEOG1M4/edit

Don't forget to enable telemetry by adding "geckoview" to each scalar (under "product") from bug 1633466.

Blocks: 1649906
Blocks: 1796184

MV3 P2

Severity: -- → N/A
Type: enhancement → task
Priority: -- → P2
Whiteboard: [addons-jira]

That's too much, so blocklist v3 will be disabled on mobile at first before enabling the in-tree snapshot of the blocklist (bug 1636158).

This is no longer a concern, let's ship the blocklist v3.

Assignee: rob → amejiamarmol
QA Whiteboard: [geckoview:m113]
Priority: P2 → P1
Attachment #9324285 - Attachment description: WIP: Bug 1639050 - Enable blocklist v3 on Android → Bug 1639050 - Enable blocklist v3 on Android

For future reference, I documented the relevant context, options considered and final design at https://docs.google.com/document/d/1tXuykhI6oaL68OKYT0z_qXq9RyHzIlxxeYlxDEOG1M4/edit ( "Design to enable blocklist v3 on Android" )

(In reply to Rob Wu [:robwu] from comment #1)

Don't forget to enable telemetry

The telemetry aspects of blocklist v3 on Android are part of bug 1820155.

Depends on: 1820155
Attachment #9324285 - Attachment description: Bug 1639050 - Enable blocklist v3 on Android → Bug 1639050 - Enable blocklist v3 on Android nightly
Blocks: 1824863
Summary: Enable blocklist v3 on Android → Enable blocklist v3 on Android on Nightly
Pushed by amejiamarmol@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/92dddcb5cf02 Enable blocklist v3 on Android nightly r=geckoview-reviewers,robwu,calu
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
Regressions: 1830066
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: