Closed Bug 1644907 Opened 5 years ago Closed 4 years ago

Intermittent Tier 2 Test Verify browser/components/urlbar/tests/browser/browser_top_sites.js | Test timed out -

Categories

(Firefox :: Address Bar, defect, P5)

defect
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 79
Iteration:
79.2 - June 15 - June 28
Tracking Status
firefox-esr68 --- unaffected
firefox77 --- unaffected
firefox78 --- unaffected
firefox79 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mak)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Filed by: btara [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=305853357&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/SI89pGaJQeemrZl2kDZOdg/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/SI89pGaJQeemrZl2kDZOdg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1


...
[task 2020-06-10T21:03:32.845Z] 21:03:32     INFO - Entering test bound topSitesDisabled
[task 2020-06-10T21:03:32.845Z] 21:03:32     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_top_sites.js | check urlbar panel is not open - true == true - 
[task 2020-06-10T21:03:32.846Z] 21:03:32     INFO - Buffered messages logged at 21:02:52
[task 2020-06-10T21:03:32.846Z] 21:03:32     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_top_sites.js | check urlbar panel is not open - true == true - 
[task 2020-06-10T21:03:32.847Z] 21:03:32     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_top_sites.js | check urlbar panel is not open - true == true - 
[task 2020-06-10T21:03:32.847Z] 21:03:32     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_top_sites.js | check urlbar panel is not open - true == true - 
[task 2020-06-10T21:03:32.848Z] 21:03:32     INFO - Buffered messages logged at 21:02:53
[task 2020-06-10T21:03:32.848Z] 21:03:32     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_top_sites.js | check urlbar panel is not open - true == true - 
[task 2020-06-10T21:03:32.849Z] 21:03:32     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_top_sites.js | check urlbar panel is not open - true == true - 
[task 2020-06-10T21:03:32.849Z] 21:03:32     INFO - Buffered messages logged at 21:02:54
[task 2020-06-10T21:03:32.850Z] 21:03:32     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_top_sites.js | check urlbar panel is not open - true == true - 
[task 2020-06-10T21:03:32.852Z] 21:03:32     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_top_sites.js | check urlbar panel is not open - true == true - 
[task 2020-06-10T21:03:32.853Z] 21:03:32     INFO - Buffered messages logged at 21:02:55
[task 2020-06-10T21:03:32.853Z] 21:03:32     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_top_sites.js | check urlbar panel is not open - true == true - 
[task 2020-06-10T21:03:32.854Z] 21:03:32     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“r” modifiers=“accel,alt” id=“key_toggleReaderMode”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 1099}]
[task 2020-06-10T21:03:32.855Z] 21:03:32     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 1099}]
[task 2020-06-10T21:03:32.856Z] 21:03:32     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_top_sites.js | check urlbar panel is not open - true == true - 
[task 2020-06-10T21:03:32.856Z] 21:03:32     INFO - Buffered messages finished
[task 2020-06-10T21:03:32.857Z] 21:03:32     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_top_sites.js | Test timed out - 
[task 2020-06-10T21:03:32.858Z] 21:03:32     INFO - Leaving test bound topSitesDisabled
[task 2020-06-10T21:03:32.858Z] 21:03:32     INFO - Entering test bound topSitesNumber
[task 2020-06-10T21:03:32.859Z] 21:03:32     INFO - GECKO(3942) | MEMORY STAT | vsize 3005MB | residentFast 308MB | heapAllocated 115MB
[task 2020-06-10T21:03:32.860Z] 21:03:32     INFO - TEST-OK | browser/components/urlbar/tests/browser/browser_top_sites.js | took 45153ms
[task 2020-06-10T21:03:32.861Z] 21:03:32     INFO - checking window state
[task 2020-06-10T21:03:32.885Z] 21:03:32     INFO - TEST-START | browser/components/urlbar/tests/browser/browser_top_sites.js
[task 2020-06-10T21:03:32.890Z] 21:03:32     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-06-10T21:03:32.892Z] 21:03:32     INFO - Buffered messages logged at 21:03:32
[task 2020-06-10T21:03:32.892Z] 21:03:32     INFO - Entering test bound init
[task 2020-06-10T21:03:32.893Z] 21:03:32     INFO - Buffered messages finished
[task 2020-06-10T21:03:32.895Z] 21:03:32     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_top_sites.js | Uncaught exception received from previously timed out test - at chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_top_sites.js:448 - ReferenceError: PlacesTestUtils is not defined
[task 2020-06-10T21:03:32.896Z] 21:03:32     INFO - Stack trace:
[task 2020-06-10T21:03:32.896Z] 21:03:32     INFO - topSitesNumber@chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_top_sites.js:448:5
[task 2020-06-10T21:03:32.897Z] 21:03:32     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1064:34
[task 2020-06-10T21:03:32.898Z] 21:03:32     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1104:11
[task 2020-06-10T21:03:32.898Z] 21:03:32     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:921:14
[task 2020-06-10T21:03:32.899Z] 21:03:32     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23
[task 2020-06-10T21:03:33.363Z] 21:03:33     INFO - Leaving test bound init
Has Regression Range: --- → yes
Keywords: regression

let's see if I can figure this out.

Assignee: nobody → mak
Status: NEW → ASSIGNED

Set release status flags based on info from the regressing bug 1631848

Iteration: --- → 79.2 - June 15 - June 28

This seems to timeout when it closes the separate window and the urlbar panel. My only theory so far is that when the PB window closes we move focus back to the main window and retained results reopen the panel, while we try to close it, so maybe there's a race where the panel stays open and promisePopupClose hangs indefinitely. I am not sure why bug 1631848 would make a difference, but of course there could just be a time skew.
Though this should be verified by logging on Try.

I confirmed on Try that we hang on waiting the panel to close, thus probably my theory is sound.

Also cleans up some test boilerplate:

  1. avoid waitForFocus passing in urlbar tests
  2. avoid useless window.gSomething
  3. avoid useless UrlbarTestUtils imports
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/3add3a174755 Fix intermittent failure due to not passing the appropriate window to syntehsize methods. r=adw
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
Points: --- → 2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: