Closed
Bug 1649655
Opened 4 years ago
Closed 4 years ago
[MIPS] Fix build issues caused by recent change (visitWasmRegisterResult)
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla80
People
(Reporter: zhaojiazhong-hf, Assigned: zhaojiazhong-hf)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr78+
|
Details |
Failed to build js on mips machine due to some changes in D80820:
js/src/jit/CodeGenerator.cpp:6800: undefined reference to 'js::jit::CodeGenerator::visitWasmRegisterResult(js::jit::LWasmRegisterResult*)'
|
Assignee | |
Comment 1•4 years ago
|
||
The change's bug id is 1646787, and it may be security-related, I don't have the access to the bug and revision.
According to the code, the bug seems only affect x64 platform, so I will just add an empty visitWasmRegisterResult function to mips platform just like arm and x86.
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → zhaojiazhong-hf
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a82ed51397f1
[MIPS] Add CodeGenerator::visitWasmRegisterResult function. r=lth
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
|
||
Comment 5•4 years ago
|
||
Comment on attachment 9160558 [details]
Bug 1649655 - [MIPS] Add CodeGenerator::visitWasmRegisterResult function. r=lth
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: Build failure on MIPS following bug 1646787.
- User impact if declined:
- Fix Landed on Version: 80
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): NPOTB
- String or UUID changes made by this patch:
Attachment #9160558 -
Flags: approval-mozilla-esr78?
|
||
Comment 6•4 years ago
|
||
Comment on attachment 9160558 [details]
Bug 1649655 - [MIPS] Add CodeGenerator::visitWasmRegisterResult function. r=lth
Approved for 78.4esr.
Attachment #9160558 -
Flags: approval-mozilla-esr78? → approval-mozilla-esr78+
|
|
||
Comment 7•4 years ago
|
||
| uplift | ||
status-firefox-esr78:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•