Closed Bug 16519 Opened 25 years ago Closed 24 years ago

NPP_DestroyStream() invoked too often for 4.0 plugin

Categories

(Core Graveyard :: Plug-ins, defect, P3)

x86
Windows NT
defect

Tracking

(Not tracked)

VERIFIED FIXED
Future

People

(Reporter: grandma, Assigned: serhunt)

References

Details

Attachments

(1 file)

Using Shockwave, I loaded a movie whose SRC was 24380 bytes long (a local file), and it aborted the stream before downloading the entire file. Logging the plugin methods called, I find : NPP_NewStream ( returns NPERR_NO_ERROR ) NPP_WriteReady ( returns 32678 ) NPP_Write ( offset 0, len 8192, returns 8192 ) NPP_DestroyStream ( movie won't play cause it ain't all there ! ) If I skip handling NPP_DestroyStream() I get NPP_NewStream ( returns NPERR_NO_ERROR ) NPP_WriteReady ( returns 32678 ) NPP_Write ( offset 0, len 8192, returns 8192 ) NPP_DestroyStream ( do nothing ) NPP_WriteReady ( returns 32678 ) NPP_Write ( offset 8192, len 8192, returns 8192 ) NPP_DestroyStream ( do nothing ) NPP_WriteReady ( returns 32678 ) NPP_Write ( offset 16384, len 8192, returns 8192 ) NPP_DestroyStream ( do nothing ) NPP_WriteReady ( returns 32678 ) NPP_Write ( offset 16384, len 7996, returns 7996 ) NPP_DestroyStream ( does the real stream end and movie plays ) Furthermore, if I alter my NPP_WriteReady() I get NPP_WriteReady ( returns 8000 ) NPP_Write ( offset 0, len 8000, returns 8000 ) NPP_WriteReady ( returns 8000 ) NPP_Write ( offset 8000, len 192, returns 192 ) NPP_DestroyStream ( altered to do nothing ) ... And so, I think NPP_DestroyStream() is being called when your buffer (8192) is consumed, in addition to when the stream en
Blocks: 18951
Blocks: 20203
Shrirang is now QA owner for Plug-ins; QA assigning all of my Plug-ins bugs over to him.
Status: NEW → ASSIGNED
This seems to be a side effect of a workaround for the bug 13122.
Right, that's what I was looking at too. Let me do more testing before I check this in.
Target Milestone: M13
NPP_DestroyStream() is no longer invoked too often, but I will leave this open since it should be reviewd when AsFileOnly Plugin support arrives.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → LATER
Latering
Reopening since disk cache has arrived, and marking dup of 23667.
Status: RESOLVED → REOPENED
Resolution: LATER → ---
*** This bug has been marked as a duplicate of 23667 ***
Status: REOPENED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → DUPLICATE
Reopening and adding dependency to bug 23667. See my comment in 23667.
Status: RESOLVED → REOPENED
Depends on: 23667
Resolution: DUPLICATE → ---
No longer depends on: 23667
Mass moving old milestone bugs to M16
Target Milestone: M13 → M16
M16 has been out for a while now, these bugs target milestones need to be updated.
No longer blocks: 18951
No longer blocks: 20203
Keywords: 4xp
Peter, can you check this bug against a recent build to see if it is still valid?
Blocks: 55959
Not a Netscape 6 RTM blocker. FUTURE. This bug has been marked Future because the Netscape engineer it is assigned to is overburdened.
Target Milestone: M16 → Future
From the original comment "... aborted the stream before downloading the entire ...". This was fixed a long time ago (summer) ... clearly streams are downloading fully or none of the content would play.
This bug has been FIXED (probably a long time ago). NPP_DestroyStream should be called correctly now or 4.x plugins wouldn't be working.
Status: REOPENED → RESOLVED
Closed: 25 years ago24 years ago
Resolution: --- → FIXED
marking verif based on earlier comments.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: