Prevent script from calling nsIWebBrowserPrint.print()
Categories
(Core :: Printing: Setup, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox80 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
(Whiteboard: [print2020_v80])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Assignee | ||
Comment 1•4 years ago
|
||
There is only one "caller" left in the dead code that should be removed by bug 1641805. I don't have the time to figure out a proper patch to that bug right now, but that shouldn't stop us marking this API [noscript] to make reviews of changes to its implementation easier to review.
Assignee | ||
Comment 2•4 years ago
|
||
Comment 4•4 years ago
|
||
Backed out for failures on browser_DownloadPDFSaver.js along with Bug 1652322 and Bug 1652318
backout: https://hg.mozilla.org/integration/autoland/rev/22f5f7e914449bde3bee21a322d67248cd5e0254
failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309507781&repo=autoland&lineNumber=39154
[task 2020-07-12T16:05:38.687Z] 16:05:38 INFO - TEST-PASS | toolkit/components/downloads/test/browser/browser_DownloadPDFSaver.js | Download window reference is a weak ref -
[task 2020-07-12T16:05:38.687Z] 16:05:38 INFO - TEST-PASS | toolkit/components/downloads/test/browser/browser_DownloadPDFSaver.js | Download window exists during test -
[task 2020-07-12T16:05:38.687Z] 16:05:38 INFO - Buffered messages finished
[task 2020-07-12T16:05:38.687Z] 16:05:38 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/downloads/test/browser/browser_DownloadPDFSaver.js | Uncaught exception - DownloadError: this._webBrowserPrint.print is not a function
[task 2020-07-12T16:05:38.687Z] 16:05:38 INFO - Stack trace:
[task 2020-07-12T16:05:38.687Z] 16:05:38 INFO - DownloadError@resource://gre/modules/DownloadCore.jsm:1696:16
[task 2020-07-12T16:05:38.687Z] 16:05:38 INFO - D_start/<@resource://gre/modules/DownloadCore.jsm:557:20
[task 2020-07-12T16:05:38.687Z] 16:05:38 INFO - Leaving test bound test_createDownload_pdf_private
[task 2020-07-12T16:05:38.688Z] 16:05:38 INFO - Entering test bound test_createDownload_pdf_not_private
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Comment 6•4 years ago
|
||
bugherder |
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Description
•