Removing a contact using drag to another addressbook or delete loses scroll position in addressbook, resets to top
Categories
(Thunderbird :: Address Book, defect)
Tracking
(thunderbird_esr78+ fixed, thunderbird81 fixed)
People
(Reporter: wsmwk, Assigned: darktrojan)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr78+
|
Details |
Works in 68, fails in 79 beta (and I presume also in 78)
Removing a contact using drag to another addressbook or delete loses scroll position in addressbook.
|
Reporter | |
Updated•4 years ago
|
|
||
Comment 1•4 years ago
|
||
Which scroll position do you mean? Of the addressbooks? That requires quite a lot of address books....
I don't see that on trunk
|
|
Reporter | |
Comment 2•4 years ago
|
||
I should have been clear with the steps - it loses position WITHIN an addressbook.
- have an addressbook of say 50
- scroll to last contact so that the first contact is now out of view
- delete a contact
|
|
Reporter | |
Comment 3•4 years ago
|
||
Another manifestation of this, is when a search is performed with All Address Books selected, and you drag a contact to another address book, the list of contacts goes blank - at least on 81 beta
|
Assignee | |
Comment 4•4 years ago
|
||
That'll be caused by these three lines. I don't know why they exist.
|
|
Assignee | |
Comment 5•4 years ago
|
||
Comment 0 will be from these lines … I know why they exist, but I wonder if I can get rid of them now.
|
|
Assignee | |
Comment 6•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 7•4 years ago
|
||
(In reply to Geoff Lankow (:darktrojan) from comment #5)
Comment 0 will be from these lines … I know why they exist, but I wonder if I can get rid of them now.
I decided not to, given that this patch should be uplifted I didn't want to cause a regression with it. I had to add the getFirstVisibleRow/scrollToRow bit anyway so removing those lines made no difference.
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/ee88f4ff9950
Fix address book scroll and drag problems. r=mkmelin
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
Reporter | |
Comment 9•4 years ago
|
||
Comment on attachment 9172956 [details]
Bug 1655235 - Fix address book scroll and drag problems. r?mkmelin
[Triage Comment]
Approved for beta
Let's remember to test the candidate build
|
||
Comment 10•4 years ago
|
||
| bugherder uplift | ||
Thunderbird 81.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/aa17f2793fb7
|
|
||
Updated•4 years ago
|
|
||
Comment 11•4 years ago
|
||
Looks like it is working properly in my testing of 81.0b3 on Ubuntu 18.04 LTS.
|
|
Assignee | |
Comment 12•4 years ago
|
||
Comment on attachment 9172956 [details]
Bug 1655235 - Fix address book scroll and drag problems. r?mkmelin
[Approval Request Comment]
Regression caused by (bug #): Bug 1636019 et al.
User impact if declined: UI glitch
Testing completed (on c-c, etc.): Since 81.0b3.
Risk to taking this patch (and alternatives if risky): Small.
|
|
Reporter | |
Comment 13•4 years ago
|
||
Comment on attachment 9172956 [details]
Bug 1655235 - Fix address book scroll and drag problems. r?mkmelin
[Triage Comment]
Approved for esr78
|
|
||
Comment 14•4 years ago
|
||
| bugherder uplift | ||
Thunderbird 78.3.0:
https://hg.mozilla.org/releases/comm-esr78/rev/22bd4b3b1b45
Description
•