Closed Bug 1657982 Opened 4 years ago Closed 4 years ago

Make test_bug593174.html to pass on Fission

Categories

(Core :: DOM: Navigation, task, P3)

task

Tracking

()

RESOLVED DUPLICATE of bug 1668357
Fission Milestone M6c

People

(Reporter: smaug, Assigned: mbrodesser-Igalia)

References

Details

(Whiteboard: waiting on session history)

Attachments

(1 obsolete file)

No description provided.

Session history blocks our Nightly experiment so tracking session history test failures for Fission Nightly milestone M6b.

Fission Milestone: --- → M6b
Blocks: 1652554
No longer blocks: fission
Fission Milestone: M6b → M6c
Depends on: fission-history-m6b
No longer depends on: fission-history
Severity: -- → S3
Priority: -- → P3

Passes locally with ./mach mochitest --setpref="fission.sessionHistoryInParent=true" --enable-xorigin-tests --enable-fission dom/tests/mochitest/bugs/test_bug593174.html. Fails without fission.sessionHistoryInParent=true. Hence, it should be tested on Try, once bug 1656208 is fixed.

Hi Neha, this blocks bug 1652554 which is marked M6b. Should we detach it from there?

Flags: needinfo?(nkochar)
Assignee: nobody → mbrodesser
Status: NEW → ASSIGNED
Fission Milestone: M6c → M6b
Flags: needinfo?(nkochar)
Whiteboard: waiting on session history

(In reply to Jens Stutte [:jstutte] (REO for FF 81) from comment #3)

Hi Neha, this blocks bug 1652554 which is marked M6b. Should we detach it from there?

No, I'll move the meta to M6c to better reflect many of the dependency bugs. Each test should be reviewed in light of the failure cause:

  • If it's a broken feature/functionality, fix in M6b (unless it can be argued that it isn't widely used and is acceptable to be broken for some time during the nightly experiment)
  • If it's a broken test i.e. test itself needs changes to fix incorrect assumptions that were accidentally met before but are no longer true with fission, or timing/delay changes, then fix in M6c.

I'm waiting for bug 1656208 to be fixed, hence not actively working on this, hence setting Status to "NEW", but keeping it assigned to me.

Status: ASSIGNED → NEW

Requries session history in parent (bug 1656208).

Mirko has already verified that the test passes with session history pref so enabling the test itself is a trivial task that can be moved to M6c. Nothing to fix here.

Status: NEW → ASSIGNED
Type: defect → task
Fission Milestone: M6b → M6c

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mbrodesser, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(mbrodesser)
Flags: needinfo?(mbrodesser)

Mirko, sessionHistoryInParent is now enabled with Fission (in bug 1668357) so you can re-enable this (and the other tests that were waiting for SHIP) for Fission now. Thanks!

:neha: thanks for letting me know. Then bug 1656208 should be closed, or?

Flags: needinfo?(nkochar)
Depends on: 1668357
No longer depends on: fission-history-m6b
Flags: needinfo?(nkochar)

Already enabled in bug 1668357.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
Attachment #9176008 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: