Add some telemetry to measure how long it takes to collect printer information
Categories
(Core :: Printing: Setup, task, P1)
Tracking
()
People
(Reporter: jwatt, Assigned: bobowen)
References
(Blocks 1 open bug)
Details
(Whiteboard: [print2020_v81])
Attachments
(2 files)
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
(deleted),
text/plain
|
tdsmith
:
data-review+
|
Details |
We know that there's the potential for some of the operations that collect information about the available printers for the new print UI to take a long time. To help decide how much effort we should put into caching/optimizing, it would be helpful to have some histogram telemetry to measure how badly the delays can be for the various operations. Basically we should add telemetry for the Promise returning APIs on PrinterList and the objects that can be accessed via it.
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Comment 3•4 years ago
|
||
Comment on attachment 9172393 [details]
Print Background Task Data Review Form.txt
Thanks!
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, in the probe definition files and the Probe Dictionary.
- Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, the Firefox telemetry opt-out.
- If the request is for permanent data collection, is there someone who will monitor the data over time?
n/a; temporary collection
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Category 1, technical data. The histogram keys aren't mentioned in the data collection request; the description (copied over from Phab) is:
Keys describe the task, usually the information being retrieved, current possible keys are: DefaultSettings, MarginsForPaper, Printers, NamedPrinter, NamedOrDefaultPrinter, SupportsDuplex, SupportsColor, SupportsCollation, PaperList.
These are also cat 1.
- Is the data collection request for default-on or default-off?
Default-on.
- Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No.
- Is the data collection covered by the existing Firefox privacy notice?
Yes.
- Does there need to be a check-in in the future to determine whether to renew the data?
bobowen et al are responsible for renewing the collection as needed.
- Does the data collection use a third-party collection tool?
No.
Updated•4 years ago
|
Comment 5•4 years ago
|
||
Backed out changeset ca085d770da4 (Bug 1660686) for causing bustage in PrintBackgroundTask.h CLOSED TREE
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314324956&repo=autoland&lineNumber=89456
Backout: https://hg.mozilla.org/integration/autoland/rev/d05ddb4058554895f18b57f713956b7a4d03420e
Assignee | ||
Comment 6•4 years ago
|
||
emilio: thanks for looking at this, failure log is in previous comment.
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Comment 8•4 years ago
|
||
bugherder |
Assignee | ||
Comment 9•4 years ago
|
||
Comment on attachment 9172202 [details]
Bug 1660686: Add telemetry for time taken in print background tasks. r=jwatt, dr=tdsmith
Beta/Release Uplift Approval Request
- User impact if declined: As part of the new Print Preview UI work, we want to be able to detect long printing system API calls that might be causing poor user experience.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Relatively simple patch that adds telemetry to existing code.
- String changes made/needed: None
Comment 10•4 years ago
|
||
Comment on attachment 9172202 [details]
Bug 1660686: Add telemetry for time taken in print background tasks. r=jwatt, dr=tdsmith
Approved for 81.0b5.
Comment 11•4 years ago
|
||
bugherder uplift |
Updated•4 years ago
|
Updated•4 years ago
|
Updated•3 years ago
|
Description
•