Closed Bug 1662014 Opened 4 years ago Closed 4 years ago

Delete unused codepaths for scroll update propagation

Categories

(Core :: Panning and Zooming, task)

task

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 3 open bugs)

Details

Attachments

(4 files)

After bug 1662013 there's a bunch of code we can remove, because it gets replaced by the ScrollPositionUpdate array. I'm mostly splitting this out into a separate bug because there's a patch for bug 1661903 "in between" the patches for bug 1662013 and this bug, and also so that I can land this a bit more incrementally.

This is the only place that uses the mSmoothScrollOffset any more, and it
doesn't really need to as a local variable suffices.

Depends on D88747

This should be mostly equivalent to the old code, and unblocks deletion of
some fields in FrameMetrics.

Depends on D88748

These things are all unused now.

Depends on D88749

The only place these fields are still read are for detecting if an APZ animation
is pending (not yet submitted in a transaction) and we can replace that code
with something simpler. And then delete the unused fields.

Depends on D88750

Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/67d2d087ca1c Stop using the mSmoothScrollOffset field. r=botond https://hg.mozilla.org/integration/autoland/rev/d13968a06d1f Update some TiledContentClient code to use the ScrollPositionUpdate array. r=botond https://hg.mozilla.org/integration/autoland/rev/c8c899745993 Remove unused fields/APIs. r=botond,tnikkel https://hg.mozilla.org/integration/autoland/rev/afe9bfd9f1ab Drop mRelativeOffset and mLastSmoothScrollOrigin. r=tnikkel,botond
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: