Closed Bug 1666617 Opened 4 years ago Closed 4 years ago

Add RefreshObserver markers with backtraces

Categories

(Core :: Layout, enhancement)

Product:
Core
Component:
Layout
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
83 Branch
Tracking Flags:
Tracking Status
firefox83 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(6 files)

Bug 1666617 - Add RefreshObserver profiler markers, r=smaug
(deleted), text/x-phabricator-request
Details
Bug 1666617 - Move kFlushTypeNames into FlushType.h so that it can be used from other files. r=smaug
(deleted), text/x-phabricator-request
Details
Bug 1666617 - Allow creating MarkerInnerWindowId with a Maybe<uint64_t>. r=gerald
(deleted), text/x-phabricator-request
Details
Bug 1666617 - Add an observer description argument to AddRefreshObserver. r=smaug
(deleted), text/x-phabricator-request
Details
Bug 1666617 - Add refresh observer descriptions to the RefreshDriverTick markers. r=smaug
(deleted), text/x-phabricator-request
Details
Bug 1666617 - Fix a typo in the word viewport. r=smaug
(deleted), text/x-phabricator-request
Details

As proposed in bug 1661054:
When the refresh driver keeps firing, and it is doing so because it still has observers, it would be nice to get some information about the observers from a profile. We can provide that information in a RefreshObservers profiler marker.

Example profile: https://share.firefox.dev/3mJ8kDM

Added refresh observer string descriptions: https://share.firefox.dev/3mLIPld

Oh, I just realized that there are many RefreshDriver observer kinds which do not go through AddRefreshObserver, but do end up being respected by HasObservers(). For example, mPendingFullscreenEvents comes from ScheduleFullscreenEvent().

Depends on D91379

Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/31c23ad979bf Move kFlushTypeNames into FlushType.h so that it can be used from other files. r=smaug https://hg.mozilla.org/integration/autoland/rev/d1c2e8215817 Allow creating MarkerInnerWindowId with a Maybe<uint64_t>. r=gerald https://hg.mozilla.org/integration/autoland/rev/36006654190e Add RefreshObserver profiler markers, r=smaug https://hg.mozilla.org/integration/autoland/rev/049367bd2e8a Add an observer description argument to AddRefreshObserver. r=smaug https://hg.mozilla.org/integration/autoland/rev/549cb9b27480 Add refresh observer descriptions to the RefreshDriverTick markers. r=smaug https://hg.mozilla.org/integration/autoland/rev/e016eb0691ad Fix a typo in the word viewport. r=smaug
Regressions: 1684788
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: