Closed Bug 1669526 Opened 4 years ago Closed 4 years ago

Don't show the heuristic result for partially typed token aliases and show all the matching token aliases

Categories

(Firefox :: Address Bar, enhancement, P2)

Product:
Firefox
Component:
Address Bar
Type:
enhancement
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Iteration:
84.1 - Oct 19 - Nov 01
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: mak, Assigned: bugzilla)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1669526 - Don't show the heuristic result for partially typed token aliases and show all the matching token aliases. r?adw!
(deleted), text/x-phabricator-request
Details

UX proposed these changes.

When typing part of a token alias:

  1. the token alias will be autofilled, but we won't show an heuristic result
  2. show all the token aliases matching the partially types alias, the autofilled one should be the first one

When pressing Enter: the autofilled token should change to search mode
When pressing down or tab: enter search mode for the selected engine (the first down/tab will in practice act the same as pressing Enter)

The idea is that Down, Tab and Enter will all allow to fill the proposed engine, then you can still tab or down to the next ones.

Points: --- → 3
Blocks: 1647921
Summary: Don't show the heuristic result for partially typed token aliases and show all the aliases matching → Don't show the heuristic result for partially typed token aliases and show all the matching token aliases
Priority: P3 → P2
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 84.1 - Oct 19 - Nov 01

The heavily nested structure of UrlbarInput.setValueFromResult made it difficult to handle a result that was both a keywordoffer and autofilled. I took this opportunity to refactor setValueFromResult to be flatter. I think it's a bit easier to read now.

Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6a8ad0e28878 Don't show the heuristic result for partially typed token aliases and show all the matching token aliases. r=adw

https://hg.mozilla.org/mozilla-central/rev/6a8ad0e28878

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: