Closed Bug 1671391 Opened 4 years ago Closed 4 years ago

Fix debugger quality-of-life regressions from bug 1412202

Categories

(Core :: JavaScript Engine, defect, P1)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox81 --- unaffected
firefox82 --- unaffected
firefox83 --- wontfix
firefox84 --- wontfix
firefox85 --- wontfix
firefox86 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Bug 1671391 - Part 1: Fix eval-in-frame and Debugger.Environment access to optimized local variables in generators and async functions. r=tcampbell
(deleted), text/x-phabricator-request
Details
Bug 1671391 - Part 2: Fix frame.this access to optimized .this binding in generators and async functions. r=tcampbell
(deleted), text/x-phabricator-request
Details

A patch in bug 1412202 disables six debugger tests that use frame.environment.getVariable and frame.this to examine suspended frames.

With the optimization, these tests fail because the engine returns {optimizedOut: true} where previously it would get the correct value.

I'm not sure how much it really matters; I don't know that the devtools debugger even offers a way to inspect a generator or async task's suspended frames. Anyway, it's fixable. The solution involves (at least) teaching DebugEnvironmentProxyHandler::handleUnaliasedAccess how to access suspended GeneratorObject state.

I'm working on at least half of this—the getVariable half. While I'm in the code I'll check to see if the other half is also easy.

Priority: -- → P1

Bugbug thinks this bug is a defect, but please change it back in case of error.

Type: task → defect

Set release status flags based on info from the regressing bug 1412202

status-firefox81: --- → unaffected
status-firefox82: --- → unaffected
status-firefox83: --- → affected
status-firefox-esr78: --- → unaffected
Assignee: nobody → jorendorff

Hey Ted, when do you think you'll be able to review the patches on this bug? :)

Flags: needinfo?(tcampbell)
Flags: needinfo?(tcampbell)
Severity: -- → S3

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jorendorff, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(jorendorff)
Pushed by jorendorff@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7ddb0286dfe8 Part 1: Fix eval-in-frame and Debugger.Environment access to optimized local variables in generators and async functions. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/0f7b73eb3b5e Part 2: Fix frame.this access to optimized .this binding in generators and async functions. r=tcampbell
Flags: needinfo?(jorendorff)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: