Closed Bug 1671668 Opened 4 years ago Closed 4 years ago

Search mode chiclet colors don't match dark theme

Categories

(Firefox :: Address Bar, defect, P2)

Product:
Firefox
Component:
Address Bar
Type:
defect
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
84 Branch
Iteration:
84.1 - Oct 19 - Nov 01
Tracking Flags:
Tracking Status
firefox83 + verified
firefox84 --- verified

People

(Reporter: sdk, Assigned: bugzilla)

References

Details

Attachments

(2 files)

tabtosearch.jpg
(deleted), image/jpeg
Details
Bug 1671668 - Invert the colors in the search mode indicator in dark mode. r?adw,ntim
(deleted), text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details
Attached image tabtosearch.jpg (deleted) —

STR

  1. Focus the AwesomeBar
  2. Type a search engine keyword
  3. Press Tab to autocomplete the suggested search engine

Actual Behavior

The search engine keyword is changed to a pill that contain the search engine title but the pill use bright colors that fits more with the Light theme.

Expected Behavior

Pill colors should follow the dark theme colorscheme

Blocks: 1647921
Blocks: 1647886
No longer blocks: 1647921
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Search pill colors don't match dark theme → Search mode chiclet colors don't match dark theme
Keywords: blocked-ux

We're going to invert the colours on the chiclet when in dark mode.

[Tracking Requested - why for this release]:
UI issue with a new feature launching in 83. The fix will be CSS-only, making it low risk for uplift.

Assignee: nobody → htwyford
Severity: -- → S4
Status: NEW → ASSIGNED
Iteration: --- → 84.1 - Oct 19 - Nov 01
tracking-firefox83: --- → ?
Keywords: blocked-ux
Priority: -- → P2
Points: --- → 1
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5dc0cfd11b22 Invert the colors in the search mode indicator in dark mode. r=adw,ntim
Blocks: 1674031

https://hg.mozilla.org/mozilla-central/rev/5dc0cfd11b22

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch

Comment on attachment 9184367 [details]
Bug 1671668 - Invert the colors in the search mode indicator in dark mode. r?adw,ntim

Beta/Release Uplift Approval Request

  • User impact if declined: Dark mode colors will look wrong in new feature launching in 83.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): CSS-only.
  • String changes made/needed:
Attachment #9184367 - Flags: approval-mozilla-beta?

Comment on attachment 9184367 [details]
Bug 1671668 - Invert the colors in the search mode indicator in dark mode. r?adw,ntim

Low risk, approved for 83 beta 6, thanks.

Attachment #9184367 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Replicated the issue on Firefox Nightly 83.0a1 dated 10/14

Verified fix on Windows10 64bit , Ubuntu 20 64bit , and MacOS 10.14
Using: Latest Firefox Nightly 84.0a1 + Firefox Beta 83.0b6

the color of the "dark mode" search shortcut container is dark blue.

Status: RESOLVED → VERIFIED
status-firefox83: fixed → verified
status-firefox84: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: