Closed Bug 1676057 Opened 4 years ago Closed 4 years ago

prevent scrollbar buttons from being shown on Linux with the non-native theme

Categories

(Core :: Widget: Gtk, task)

task

Tracking

()

RESOLVED FIXED
84 Branch
Fission Milestone M7
Tracking Status
firefox84 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(2 files)

The non-native theme on Linux has scrollbars that look like Adwaita. Even if the Gtk theme indicates that it does have scrollbar buttons, we still shouldn't show them.

Whether scrollbar buttons are shown is currently determined by
LookAndFeel values, and these are exposed through system metric media
features. LookAndFeel values are process-wide, but which theme is in
use is document-specific. (It can be the platform's native theme or the
native basic theme, depending on Document::ShouldAvoidNativeTheme.) So
if nsNativeBasicTheme on Linux needs to not support scrollbar buttons,
we can't do this by forcing the LookAndFeel values to be false.

So instead, we change the media features so that instead of being system
metrics they have their own evaluation function that also calls into a
function on the theme the document is using.

Assignee: nobody → cam
Status: NEW → ASSIGNED

Tracking for Fission Beta milestone (M7).

Fission Milestone: --- → M7
Attached file Bug 1676057 - Test. (deleted) —
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/89bf76725360 Disable scrollbar buttons when non-native theme is in use on Linux. r=emilio,spohl https://hg.mozilla.org/integration/autoland/rev/be330dd56b10 Test. r=spohl
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: