Closed
Bug 1679780
Opened 4 years ago
Closed 4 years ago
remove <deck> from calendar-creation.xhtml
Categories
(Calendar :: General, task)
Calendar
General
Tracking
(thunderbird_esr78 wontfix, thunderbird84 wontfix)
RESOLVED
FIXED
85 Branch
People
(Reporter: khushil324, Assigned: khushil324)
References
Details
Attachments
(3 files, 1 obsolete file)
|
(deleted),
patch
|
darktrojan
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
image/png
|
Details |
Screenshot from 2021-02-05 10-31-40.png
No description provided.
|
Assignee | |
Comment 1•4 years ago
|
||
Remove <deck> from https://searchfox.org/comm-central/rev/bfc7644683950de390d29602ccf43c7fc358491e/calendar/base/content/dialogs/calendar-creation.xhtml#39
It has five children. These we can show/hide as needed.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Attachment #9190309 -
Flags: review?(alessandro)
|
|
Assignee | |
Updated•4 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 3•4 years ago
|
||
Comment on attachment 9190309 [details] [diff] [review]
Bug-1679780_de-deck-calendar-creation-xhtml-0.patch
Review of attachment 9190309 [details] [diff] [review]:
-----------------------------------------------------------------
::: calendar/base/content/dialogs/calendar-creation.js
@@ +293,1 @@
> * @param {string} id The id of the panel node to select.
Nit: update this comment to respect the format we're using (eg. @param {string} id - The id of the panel node to select.)
@@ +293,5 @@
> * @param {string} id The id of the panel node to select.
> */
> function selectPanel(id) {
> + for (let element of document.getElementById("calendar-creation-dialog").children) {
> + element.hidden = element.getAttribute("id") != id;
element.id != id;
@@ +371,5 @@
> return;
> }
>
> let disabled = false;
> + switch (selectedPanel.getAttribute("id")) {
selectedPanel.id
Attachment #9190309 -
Flags: review?(alessandro) → review+
|
|
Assignee | |
Comment 4•4 years ago
|
||
Attachment #9190309 -
Attachment is obsolete: true
Attachment #9190466 -
Flags: review+
|
|
Assignee | |
Updated•4 years ago
|
Keywords: checkin-needed-tb
|
||
Comment 5•4 years ago
|
||
For calendar, maybe have Geoff sign off as well
status-thunderbird84:
--- → wontfix
status-thunderbird_esr78:
--- → wontfix
Keywords: checkin-needed-tb
Target Milestone: --- → 85 Branch
|
|
Assignee | |
Comment 6•4 years ago
|
||
|
|
Assignee | |
Comment 7•4 years ago
|
||
Should we check in the patch now?
|
|
||
Comment 8•4 years ago
|
||
Please have Geoff take a look as well.
|
|
Assignee | |
Comment 9•4 years ago
|
||
Sure.
|
|
Assignee | |
Updated•4 years ago
|
Attachment #9190466 -
Flags: review+ → review?(geoff)
|
||
Updated•4 years ago
|
Attachment #9190466 -
Flags: review?(geoff) → review+
|
|
Assignee | |
Updated•4 years ago
|
Keywords: checkin-needed-tb
|
||
Comment 10•4 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/b2c5ca90c712
remove <deck> XUL element from calendar-creation.xhtml dialog. r=aleca,darktrojan
|
||
Comment 11•4 years ago
|
||
Fix the panel height so that content is not clipped.
Attachment #9201299 -
Flags: review?(alessandro)
|
|
||
Comment 12•4 years ago
|
||
It looks like this without the fix
|
|
||
Updated•4 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 13•4 years ago
|
||
Comment on attachment 9201299 [details] [diff] [review]
1679780-panel-height.patch
Review of attachment 9201299 [details] [diff] [review]:
-----------------------------------------------------------------
Good catch!
Attachment #9201299 -
Flags: review?(alessandro) → review+
|
|
||
Updated•4 years ago
|
Keywords: checkin-needed-tb
|
|
||
Comment 14•4 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/cc87eccf2a12
Fix panel-select-calendars height in calendar-creation dialog. r=aleca
Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•