Set fission.autostart=false when moz:debuggerAddress is requested
Categories
(Testing :: geckodriver, task, P1)
Tracking
(firefox85 fixed)
| Tracking | Status | |
|---|---|---|
| firefox85 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
(Depends on 1 open bug)
Details
Attachments
(3 files, 1 obsolete file)
Similar to bug 1680101 for Puppeteer the Remote Agent needs to force disable Fission until it is Fission compatible (bug 1600054) . We have to do that because Fission gets partially enabled for Nightly users now, and this would break the Remote Agent's functionality.
So if the moz:debuggerAddress is set to true the preference fission.autostart needs to be set to false.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
||
Comment 5•4 years ago
|
||
Backed out for perma failures.
Log: https://treeherder.mozilla.org/logviewer?job_id=323480649&repo=autoland&lineNumber=88567
Backout: https://hg.mozilla.org/integration/autoland/rev/334360d11869b856ff2d6352614ced3b2ad66f7c
|
|
Assignee | |
Comment 7•4 years ago
|
||
So the problem is that for Fission jobs in CI we will always have fission.autostart set to true by --enable-fission. That means that the preference is force-fully set, and geckodriver is not going to disable Fission. That clearly breaks the tests. As such this specific test cannot be run for Fission jobs in CI.
|
||
Comment 9•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6e45b8c280e0
https://hg.mozilla.org/mozilla-central/rev/c22c3f6c8ead
|
|
Assignee | |
Comment 10•4 years ago
|
||
(In reply to Web Platform Test Sync Bot (Matrix: #interop:mozilla.org) from comment #6)
Upstream PR was closed without merging
James, shouldn't the Github PR be reopened automatically?
|
||
Comment 11•4 years ago
|
||
The bot did reopen it, but it's failing presumably due to the issue in https://phabricator.services.mozilla.com/D99253 Maybe I should just attach that commit to this bug.
|
|
||
Comment 12•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
||
Comment 13•4 years ago
|
||
|
||
Comment 14•4 years ago
|
||
|
||
Comment 15•4 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 16•4 years ago
|
||
(In reply to James Graham [:jgraham] from comment #11)
The bot did reopen it, but it's failing presumably due to the issue in https://phabricator.services.mozilla.com/D99253 Maybe I should just attach that commit to this bug.
Given that your follow-up landed on mozilla-central I assume some manual work is needed from your side to get both merged?
|
|
||
Updated•4 years ago
|
|
|
||
Comment 19•4 years ago
|
||
|
||
Comment 20•4 years ago
|
||
| bugherder | ||
Description
•