Closed Bug 1680733 Opened 4 years ago Closed 4 years ago

Case-sensitive "websocket" upgrade request header check breaks WebSocket connection

Categories

(Remote Protocol :: Agent, defect, P1)

Product:
Remote Protocol
Component:
Agent
Type:
defect

Tracking

(firefox85 fixed)

Status:
RESOLVED FIXED
Milestone:
85 Branch
Tracking Flags:
Tracking Status
firefox85 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

Bug 1680733 - [remote] Use a case-insensitive check for WebSocket upgrade header value.
(deleted), text/x-phabricator-request
Details

We incorrectly check the WebSocket upgrade request header and only allow websocket:

https://searchfox.org/mozilla-central/rev/6bb59b783b193f06d6744c5ccaac69a992e9ee7b/remote/server/WebSocketHandshake.jsm#85

This breaks several websocket client libraries given that also WebSocket and WebSocket gets send.

The value should actually be case-insensitive as this network code shows.

Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0be8be3dc849 [remote] Use a case-insensitive check for WebSocket upgrade header value. r=remote-protocol-reviewers,jgraham

https://hg.mozilla.org/mozilla-central/rev/0be8be3dc849

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox85: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: