Closed
Bug 1683228
Opened 4 years ago
Closed 4 years ago
ConsoleInstance.cpp incorrectly fallback to All when maxLogLevelPref doesn't exist
Categories
(Core :: DOM: Core & HTML, defect, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
86 Branch
People
(Reporter: rnons, Assigned: rnons)
References
Details
Attachments
(2 files)
From the doc https://searchfox.org/mozilla-central/rev/8d722de75886d6bffc116772a1db8854e34ee6a7/dom/webidl/Console.webidl#229-232, if the pref doesn't exist, should fallback to the maxLogLevel, but the implementation https://searchfox.org/mozilla-central/rev/8d722de75886d6bffc116772a1db8854e34ee6a7/dom/console/ConsoleInstance.cpp#45 always fallback to All
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → remotenonsense
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D100074.
|
||
Updated•4 years ago
|
Keywords: leave-open
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/integration/autoland/rev/5077eb1ad67c
Fallback to maxLogLevel when maxLogLevelPref doesn't exist. r=smaug
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
Severity: -- → S3
Priority: -- → P3
|
|
||
Updated•4 years ago
|
Attachment #9194125 -
Attachment description: Bug 1683228 - Observe maxLogLevelPref and update maxLogLevel accordingly. r=smaug → Bug 1683228 - Check maxLogLevelPref value each time and use it when available. r=smaug
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3bc433def946
Check maxLogLevelPref value each time and use it when available. r=smaug
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
|
|
||
Comment 7•4 years ago
|
||
No need to close the bug yourself. It will (should) get closed when the actual merge to mozilla-central happens (and the final changeset is added to the bug, like comment 6.)
Target Milestone: --- → 86 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•