Image attachments loaded in message reader pane instead of opened
Categories
(Thunderbird :: Message Reader UI, defect, P1)
Tracking
(thunderbird_esr78 unaffected, thunderbird86+ verified)
Tracking | Status | |
---|---|---|
thunderbird_esr78 | --- | unaffected |
thunderbird86 | + | verified |
People
(Reporter: darktrojan, Assigned: darktrojan)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
|
Details |
I don't know why but something in the process of saving an attachment isn't working properly any more. Image attachments get loaded in the message pane, which isn't what we want.
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
I've worked out this doesn't happen if the message pane has not loaded a web page at any point. So if you don't have the Start Page enabled, only load messages, then open an attachment, it works as before. Not sure why.
Sorry I filed bug 1687937 for more variations. Text and PDF attachments behave weird as well.
Comment 3•4 years ago
|
||
I think this is the same issue: Having a web page, for me bugzilla bugs, loaded in a Feed and clicking on a link opens the link in this view instead opening in the browser.
Comment 4•4 years ago
|
||
Does priority=P2 square with severity=blocker?
Assignee | ||
Comment 5•4 years ago
|
||
I was working on something more important but it turned out not to be a thing. I've been on this ever since, and I think at last I have a fix. Waiting on a Try run.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 7•4 years ago
|
||
The presence of this flag forces a docShell to pass loading onto the external helper app service. In some special cases we don't want this, so I've white-listed certain content types.
Depends on D102891
Assignee | ||
Updated•4 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/49c00a6f17ef
Set nsIChannel::DISPOSITION_ATTACHMENT on attachments so they open when expected. r=mkmelin
Assignee | ||
Comment 9•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 10•4 years ago
|
||
Comment on attachment 9200577 [details]
Bug 1687847 - Set nsIChannel::DISPOSITION_ATTACHMENT on newsgroup attachments too. r?mkmelin
[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: attachments in newsgroups behave badly
Testing completed (on c-c, etc.): not yet, this is a pre-emptive request
Risk to taking this patch (and alternatives if risky): very small, this is newsgroups only, and I've already made similar changes to the other protocols
Updated•4 years ago
|
Comment 11•4 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/001de226b946
Set nsIChannel::DISPOSITION_ATTACHMENT on newsgroup attachments too. r=mkmelin
Comment 12•4 years ago
|
||
+ if (spec.Find("part=") >= 0 && spec.Find("type=message/rfc822") < 0 &&
+ spec.Find("type=application/x-message-display") < 0 &&
+ spec.Find("type=application/pdf") < 0) {
We usually test for kNotFound.
Comment 13•4 years ago
|
||
Comment on attachment 9200577 [details]
Bug 1687847 - Set nsIChannel::DISPOSITION_ATTACHMENT on newsgroup attachments too. r?mkmelin
[Triage Comment]
Approved for beta
Comment 14•4 years ago
|
||
bugherder uplift |
Thunderbird 86.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/d7a7cf37f47e
Comment 15•4 years ago
|
||
Image attachments no longer open in the message reader pane in my tests of 86.0b2 on Windows 10 and Fedora 33 Workstation.
Description
•