Get rid of nsMsgPrintEngine.cpp, handle printing in msgPrintEngine.js
Categories
(MailNews Core :: Printing, task)
Tracking
(thunderbird_esr78 unaffected, thunderbird86 fixed)
Tracking | Status | |
---|---|---|
thunderbird_esr78 | --- | unaffected |
thunderbird86 | --- | fixed |
People
(Reporter: rnons, Assigned: rnons)
References
Details
Attachments
(2 files)
(deleted),
text/x-phabricator-request
|
rjl
:
approval-comm-beta+
|
Details |
(deleted),
text/x-phabricator-request
|
Details |
+++ This bug was initially created as a clone of Bug #1688248 +++
Currently we have both msgPrintEngine.js and nsMsgPrintEngine.cpp. nsMsgPrintEngine.cpp feels over complicated. By using printUtils.js, we should be able to get rid of nsMsgPrintEngine.cpp and handle printing in msgPrintEngine.js alone.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Will remove nsMsgPrintEngine.cpp when all printing cases work.
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Functionalities of nsMsgPrintEngine.cpp have been implemented in msgPrintEngine.js.
Depends on D103141.
Comment 3•4 years ago
|
||
I've noticed that printing happens even if you click Cancel in the print dialog. Not sure why, haven't investigated.
Apart from that, I'd like to use this new version to fix the address book/calendar printing as it'll be much easier. In fact I already have most of it complete. So don't wait for that to happen before landing.
Assignee | ||
Comment 4•4 years ago
|
||
(In reply to Geoff Lankow (:darktrojan) from comment #3)
I've noticed that printing happens even if you click Cancel in the print dialog. Not sure why, haven't investigated.
Apart from that, I'd like to use this new version to fix the address book/calendar printing as it'll be much easier. In fact I already have most of it complete. So don't wait for that to happen before landing.
Good catch, I pushed a fix.
Assignee | ||
Updated•4 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/9d9f5b8ec38c
Handle printing in msgPrintEngine.js alone. r=mkmelin
https://hg.mozilla.org/comm-central/rev/15d2e4d89641
Remove nsMsgPrintEngine.cpp. r=mkmelin
Comment 6•4 years ago
|
||
Ping - bug 1689461 says that this bug needs to be uplifted first. Could you make the request for comm-beta with a risk assessment?
Comment 7•4 years ago
|
||
I'd take it. Without it you can't take bug 1689461 so that's a good reason.
Comment 8•4 years ago
|
||
Comment on attachment 9199443 [details]
Bug 1689042 - Handle printing in msgPrintEngine.js alone. r=mkmelin
[Triage Comment]
Accepting for beta per comment 7. This is for both patches.
Comment 9•4 years ago
|
||
bugherder uplift |
Thunderbird 86.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/915f2cb150ac
https://hg.mozilla.org/releases/comm-beta/rev/fd474dcd1595
Updated•4 years ago
|
Description
•