Closed Bug 1690396 Opened 4 years ago Closed 4 years ago

mix-blend-mode may be broken with raster roots

Categories

(Core :: Graphics: WebRender, defect)

defect

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: lsalzman, Assigned: gw)

References

(Blocks 3 open bugs)

Details

Attachments

(1 file)

This seems to manifest as fuzziness in layout/reftests/css-blending/mix-blend-mode-and-filter.svg like it is sampling something in the filter at a wrong offset, once SWGL enabled KHR_advanced_blend_equation support. As per Glenn on matrix:

I'm not entirely surprised, I'm finding it difficult to understand how any of the mix-blend stuff works in the presence of raster roots (which svg filters introduce) at the moment!
(well, it doesn't work - I've already been able to create simple test cases that are completely broken with the existing impl)

I am working on this now, as it needs to be fixed to unblock the mix-blend optimization work I'm doing anyway.

Assignee: nobody → gwatson
Blocks: 1684781

This fixes incorrect rendering when either the source or backdrop
tasks establish a raster root.

By design, it also changes mix-blend backdrop readbacks to work in
a way that can handle readbacks from picture cache tiles, which is
a follow up optimization being worked on.

Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ddd89e758a23 Refactor mix-blend-mode impl to work correctly with raster roots. r=nical

Oops, I had already found and fixed this failure - but forgotten to push the updated patch to phab. Should be fixed now, thanks!

Flags: needinfo?(gwatson)
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0788e77d2d62 Refactor mix-blend-mode impl to work correctly with raster roots. r=nical
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Status: RESOLVED → REOPENED
Flags: needinfo?(gwatson)
Resolution: FIXED → ---
Target Milestone: 87 Branch → ---

Thanks for backing out! Do we have any URLs from the crash reports? I haven't managed to repro locally yet.

Flags: needinfo?(gwatson) → needinfo?(ncsoregi)
Flags: needinfo?(ncsoregi) → needinfo?(aryx.bugmail)
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6b775dfe44a9 Refactor mix-blend-mode impl to work correctly with raster roots. r=nical
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: