Closed Bug 1690812 Opened 4 years ago Closed 4 years ago

Bug 1689359 again broke scrollbar arrows on Linux Manjaro KDE

Categories

(Core :: Widget: Gtk, defect)

defect

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox85 --- unaffected
firefox86 --- unaffected
firefox87 --- fixed

People

(Reporter: gwarser, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

History:

[rdk@on ~]$ mozregression --good  2021-01-28 -p /media/on/doc/tmplc9zis4t.mozrunner/ --pref security.sandbox.content.level:0 ^C
...

12:35.66 INFO: Downloading build from: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/bdhjyENSSyixx_ft42Ewfw/runs/0/artifacts/public%2Fbuild%2Ftarget.tar.bz2
===== Downloaded 100% =====
13:24.27 INFO: Running autoland build built on 2021-02-03 11:59:17.781000, revision d6481478
13:37.20 INFO: Launching /tmp/tmp_ehuocfz/firefox/firefox
13:37.20 INFO: Application command: /tmp/tmp_ehuocfz/firefox/firefox --allow-downgrade -profile /tmp/tmp4nmg7yyo
13:37.21 INFO: application_buildid: 20210130161107
13:37.21 INFO: application_changeset: d6481478a8e01366fb3af2e0788aa6666429d5f1
13:37.21 INFO: application_name: Firefox
13:37.21 INFO: application_repository: https://hg.mozilla.org/integration/autoland
13:37.21 INFO: application_version: 87.0a1
Was this integration build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', 'back' or 'exit' and press Enter): good
13:46.72 INFO: Narrowed integration regression window from [a3231eeb, d9e5a018] (3 builds) to [d6481478, d9e5a018] (2 builds) (~1 steps left)
13:46.73 INFO: No more integration revisions, bisection finished.
13:46.73 INFO: Last good revision: d6481478a8e01366fb3af2e0788aa6666429d5f1
13:46.73 INFO: First bad revision: d9e5a018312eccf63acbda32759d90e2f92175d7
13:46.73 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d6481478a8e01366fb3af2e0788aa6666429d5f1&tochange=d9e5a018312eccf63acbda32759d90e2f92175d7
Flags: needinfo?(emilio)
Has Regression Range: --- → yes
Regressed by: 1689359

This is just a very minor perf optimization which skips generating some
elements.

Assignee: nobody → emilio

They look ok as-is, but make it an opt-in for now.

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6e1e58e8a41d Allow users to opt-in into scrollbar-buttons on GTK. r=spohl
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/edb53b07e9c0 nsNativeThemeAndroid shouldn't support scrollbar buttons. r=mstange
Flags: needinfo?(emilio)

I'll move the second patch to some other bug.

Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch

Set release status flags based on info from the regressing bug 1689359

Thank you very much. Arrows looks good and are working.

One small issue through - every click scrolls by ~3 lines vertically or ~4 characters horizontally. Why?

Not sure off-hand, is that different from the arrow behavior from before the non-native theme landed?

(In reply to Emilio Cobos Álvarez (:emilio) from comment #10)

Not sure off-hand, is that different from the arrow behavior from before the non-native theme landed?

Ok, it was like this at least back in 78. It's good enough to be usable right now.

Thank you again for fixing arrows.

I was woried for a moment, but turns out only pref name was changed in bug 1694059 to widget.non-native-theme.gtk.scrollbar.allow-buttons

Yeah, sorry about that one :)

Attachment #9201190 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: