Closed Bug 1693682 Opened 4 years ago Closed 3 years ago

Use SessionStoreListener in GeckoView rather than SessionStateAggregator

Categories

(GeckoView :: Sandboxing, task, P1)

Product:
GeckoView
Component:
Sandboxing
Platform:
Unspecified
Android
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: droeh, Assigned: owlish)

References

Details

(Whiteboard: [geckoview:m88] [fission:android:m3][geckoview:m91][geckoview:m92][geckoview:m93][geckoview:m94][geckoview:m95])

Title speaks for itself; this helps with fission-readiness and reduces platform-specific code.

Whiteboard: [geckoview:m88] → [geckoview:m88] [fission:android:m3]
Severity: -- → S3
Priority: -- → P1
Whiteboard: [geckoview:m88] [fission:android:m3] → [geckoview:m88] [fission:android:m3][geckoview:m89]
Whiteboard: [geckoview:m88] [fission:android:m3][geckoview:m89] → [geckoview:m88] [fission:android:m3][geckoview:m90]
Whiteboard: [geckoview:m88] [fission:android:m3][geckoview:m90] → [geckoview:m88] [fission:android:m3][geckoview:m90?]
Priority: P1 → P2
Whiteboard: [geckoview:m88] [fission:android:m3][geckoview:m90?] → [geckoview:m88] [fission:android:m3][geckoview:m91?]
Assignee: droeh → nobody
Priority: P2 → P1
Whiteboard: [geckoview:m88] [fission:android:m3][geckoview:m91?] → [geckoview:m88] [fission:android:m3][geckoview:m91]
Rank: 7
Depends on: 1538291
Whiteboard: [geckoview:m88] [fission:android:m3][geckoview:m91] → [geckoview:m88] [fission:android:m3][geckoview:m91][geckoview:m92]
Whiteboard: [geckoview:m88] [fission:android:m3][geckoview:m91][geckoview:m92] → [geckoview:m88] [fission:android:m3][geckoview:m91][geckoview:m92][geckoview:m93]
Assignee: nobody → agi

Note that the parts of SessionStoreListener that collect scroll/form data were moved to SessionStoreChangeListener and SessionStoreDataCollector in bug 1572084. It sounds like both SessionStoreListener and SessionStoreChangeListener/SessionStoreDataCollector will be needed here.

Nice, thanks for the heads-up kashav.

Whiteboard: [geckoview:m88] [fission:android:m3][geckoview:m91][geckoview:m92][geckoview:m93] → [geckoview:m88] [fission:android:m3][geckoview:m91][geckoview:m92][geckoview:m93][geckoview:m94]
Assignee: agi → nobody
Rank: 7 → 3
Assignee: nobody → bugzeeeeee
Whiteboard: [geckoview:m88] [fission:android:m3][geckoview:m91][geckoview:m92][geckoview:m93][geckoview:m94] → [geckoview:m88] [fission:android:m3][geckoview:m91][geckoview:m92][geckoview:m93][geckoview:m94][geckoview:m95]

This bit of code is being removed from the code base by Andreas Farre as some refactoring around moving session management behaviour into platform code.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
No longer depends on: 1538291

Moving Android Fission bugs to the new GeckoView::Sandboxing component.

Component: General → Sandboxing
You need to log in before you can comment on or make changes to this bug.