Closed Bug 1697737 Opened 4 years ago Closed 3 years ago

Remove the NOTIFY_LISTENERS macros from nsSHistory.cpp

Categories

(Core :: DOM: Navigation, task, P2)

Product:
Core
Component:
DOM: Navigation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: pbone, Assigned: pbone)

Details

Attachments

(2 files)

Bug 1697737 - pt 1. Remove NOTIFY_LISTENERS_CANCELABLE r=nika
(deleted), text/x-phabricator-request
Details
Bug 1697737 - pt 2. Remove the NOTIFY_LISTENERS macro r=nika
(deleted), text/x-phabricator-request
Details
No description provided.

Hi Nika.

Andrew and I were discussing this and he's suggested a slightly more involved refactoring.
https://phabricator.services.mozilla.com/D107805#inline-602954
I like this idea because the call sites then show the intent more clearly, the show the loop over all listeners. Do you think this is worth-while? I realise even if it is it's probably a fairly low priority, I just like to tidy code up as I visit it.

Thanks.

Flags: needinfo?(nika)

This macro was used in two places to do the same thing. We can remove this
over-generalisation and have clearer code.

We can replace this macro with a static function to make the code here
easier to read.

Flags: needinfo?(nika)
Severity: -- → N/A
Priority: -- → P2
Attachment #9208330 - Attachment description: Bug 1697737 - pt 2. Remove the NOTIFY_LISTENERS macro → Bug 1697737 - pt 2. Remove the NOTIFY_LISTENERS macro r=nika
Pushed by pbone@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/00b62c26315f pt 1. Remove NOTIFY_LISTENERS_CANCELABLE r=nika https://hg.mozilla.org/integration/autoland/rev/85cd2aec263e pt 2. Remove the NOTIFY_LISTENERS macro r=nika

https://hg.mozilla.org/mozilla-central/rev/00b62c26315f
https://hg.mozilla.org/mozilla-central/rev/85cd2aec263e

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: