Closed Bug 1699851 Opened 4 years ago Closed 4 years ago

Avoid allocating for ArrayIteratorNext

Categories

(Core :: JavaScript Engine: JIT, task, P1)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: iain, Assigned: iain)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sp3])

Attachments

(2 files)

Bug 1699851: Improve scalar replacement of objects r=jandem
(deleted), text/x-phabricator-request
Details
Bug 1699851: Inline ArrayIteratorNext r=jandem
(deleted), text/x-phabricator-request
Details

After the branch pruning changes in bug 1697696 land, the remaining obstacles to inlining ArrayIteratorNext and doing scalar replacement on the result object are easy to fix.

On a microbenchmark, for (x of someArray) { sum += x; } is ~40% faster.

We improve by ~40% on a microbenchmark because we can scalar-replace the result object.

Depends on D109165

Pushed by iireland@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/668ca9d231cb Improve scalar replacement of objects r=jandem https://hg.mozilla.org/integration/autoland/rev/b361eb0f908c Inline ArrayIteratorNext r=jandem

Accidentally landed this before landing bug 1697696, which it depends on.

Flags: needinfo?(iireland)
Pushed by iireland@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0b3e2e877f7f Improve scalar replacement of objects r=jandem https://hg.mozilla.org/integration/autoland/rev/ab7497109e62 Inline ArrayIteratorNext r=jandem

https://hg.mozilla.org/mozilla-central/rev/0b3e2e877f7f
https://hg.mozilla.org/mozilla-central/rev/ab7497109e62

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Backed out for causing Bug 1700614

backout: https://hg.mozilla.org/mozilla-central/rev/79e3635f5be101d7e5e710b41e83d6011d4e7735

Status: RESOLVED → REOPENED
status-firefox89: fixed → ---
Flags: needinfo?(iireland)
Resolution: FIXED → ---
Target Milestone: 89 Branch → ---

Fuzz testcase in bug 1700616.

Flags: needinfo?(iireland)
Pushed by iireland@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f40ed4144a4 Improve scalar replacement of objects r=jandem https://hg.mozilla.org/integration/autoland/rev/f57a7679f7a1 Inline ArrayIteratorNext r=jandem

https://hg.mozilla.org/mozilla-central/rev/0f40ed4144a4
https://hg.mozilla.org/mozilla-central/rev/f57a7679f7a1

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Blocks: 1801189
Whiteboard: [sp3]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: