Update builders to rustc 1.51
Categories
(Firefox Build System :: Toolchains, task)
Tracking
(firefox89 fixed)
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: hsivonen, Assigned: glandium)
References
(Blocks 1 open bug)
Details
(Keywords: perf-alert)
Attachments
(3 files)
When doing this, please remove the special case for xmldecl from RUSTC_BOOTSTRAP and remove the git override for xmldecl (version 0.1.1 from crates.io works with Rust 1.51.)
|
Assignee | |
Comment 1•4 years ago
|
||
The whole point of the special case is to keep it building with versions older than 1.51.
|
Reporter | |
Comment 2•4 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #1)
The whole point of the special case is to keep it building with versions older than 1.51.
Our policy says "We require a new stable Rust starting 2 weeks after it is released.", so in two weeks, we don't need to support building with versions older than 1.51.
|
|
Assignee | |
Comment 3•4 years ago
|
||
The policy is outdated. Our MSRV is currently 1.47 and will stay there until new code needs a newer version. Bug 1695828 is open about updating the policy document.
|
|
Assignee | |
Comment 4•4 years ago
|
||
|
||
Updated•4 years ago
|
|
||
Comment 6•4 years ago
|
||
Backed out for causing wrench bustages.
Backout link:https://hg.mozilla.org/integration/autoland/rev/647f1d665b2d88c8b84ecb7e9f1bae2315f7598c
Also bustages in win 2012 debug
error: unnecessary trailing semicolon
[task 2021-03-30T09:01:26.939Z] --> wrench\src\egl.rs:470:6
[task 2021-03-30T09:01:26.939Z] |
[task 2021-03-30T09:01:26.939Z] 470 | };
[task 2021-03-30T09:01:26.939Z] | ^ help: remove this semicolon
[task 2021-03-30T09:01:26.939Z] |
[task 2021-03-30T09:01:26.939Z] = note: -D redundant-semicolons implied by -D warnings
[task 2021-03-30T09:01:26.939Z]
[task 2021-03-30T09:01:28.115Z] error: aborting due to previous error
[task 2021-03-30T09:01:28.115Z]
[task 2021-03-30T09:01:28.206Z] error: could not compile wrench
[task 2021-03-30T09:01:28.206Z]
[task 2021-03-30T09:01:28.206Z] Caused by:
[task 2021-03-30T09:01:28.206Z] process didn't exit successfully: `rustc --crate-name wrench --edition=2018 wrench\src\main.rs --error-format=jso
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 7•4 years ago
|
||
|
|
||
Comment 8•4 years ago
|
||
Patch attached. I didn't test it since it seems kinda trivial.
|
|
||
Comment 10•4 years ago
|
||
|
||
Comment 11•4 years ago
|
||
|
|
||
Comment 12•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8325da45ffd5
https://hg.mozilla.org/mozilla-central/rev/a61fef9be52b
https://hg.mozilla.org/mozilla-central/rev/ce2e93d12fee
|
||
Comment 13•4 years ago
|
||
== Change summary for alert #29539 (as of Thu, 01 Apr 2021 11:20:45 GMT) ==
Improvements:
| Ratio | Suite | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|---|
| 8% | perf_reftest_singletons | bloom-basic-2.html | linux1804-64-shippable | e10s stylo | 50.66 -> 46.72 |
| 7% | perf_reftest_singletons | bloom-basic.html | linux1804-64-shippable | e10s stylo | 50.57 -> 46.86 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=29539
|
|
||
Updated•4 years ago
|
Description
•