Crash report: https://crash-stats.mozilla.org/report/index/510d2ef1-b396-4835-83ec-652960210506

I recorded some profiles of Nightly yesterday, include page screenshots. This morning, Nightly's unsubmitted crash reporter says I have seven GPU process crash reports from profiler_screenshots code.

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll mozilla::layers::CompositingRenderTargetD3D11::BindRenderTarget gfx/layers/d3d11/TextureD3D11.cpp:1602
1 xul.dll mozilla::layers::CompositorD3D11::SetRenderTarget gfx/layers/d3d11/CompositorD3D11.cpp:608
2 xul.dll mozilla::layers::DownscaleTargetLMC::DownscaleFrom gfx/layers/composite/LayerManagerComposite.cpp:1716
3 xul.dll mozilla::layers::profiler_screenshots::ScreenshotGrabberImpl::ScaleDownWindowRenderSourceToSize gfx/layers/ScreenshotGrabber.cpp:137
4 xul.dll mozilla::layers::profiler_screenshots::ScreenshotGrabberImpl::ScaleDownWindowRenderSourceToSize gfx/layers/ScreenshotGrabber.cpp:132
5 xul.dll mozilla::layers::profiler_screenshots::ScreenshotGrabberImpl::ScaleDownWindowRenderSourceToSize gfx/layers/ScreenshotGrabber.cpp:132
6 xul.dll mozilla::layers::profiler_screenshots::ScreenshotGrabberImpl::ScaleDownWindowRenderSourceToSize gfx/layers/ScreenshotGrabber.cpp:132
7 xul.dll mozilla::layers::profiler_screenshots::ScreenshotGrabberImpl::GrabScreenshot gfx/layers/ScreenshotGrabber.cpp:162
8 xul.dll mozilla::wr::RenderCompositorLayersSWGL::MaybeGrabScreenshot gfx/webrender_bindings/RenderCompositorLayersSWGL.cpp:345
9 xul.dll mozilla::wr::RendererOGL::UpdateAndRender gfx/webrender_bindings/RendererOGL.cpp:210

Looks like something with RenderCompositorD3D11SWGL may be bugging out with profiler screenshots. Sotaro, can you take a look?

I take a look.

mCompositor->BeginFrameForWindow() needs to be called to call mProfilerScreenshotGrabber.MaybeGrabScreenshot().

There were two reports of this crash from 89 Beta (and one from 78.9.0esr).

Should we uplift this fix to 89 Beta? If this crash only affects SWGL users recording profiles, maybe we don't to bother uplifting.

(In reply to Chris Peterson [:cpeterson] from comment #5)

There were two reports of this crash from 89 Beta (and one from 78.9.0esr).

Should we uplift this fix to 89 Beta? If this crash only affects SWGL users recording profiles, maybe we don't to bother uplifting.

It's useful to have users who are reporting SW-WR performance issues submit profiles. This change seems pretty small and safe, so I think it would be good if we uplift this to avoid issues for our contributors.

https://hg.mozilla.org/mozilla-central/rev/3aa2ee514938

The patch landed in nightly and beta is affected.
:sotaro, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.