Improve the ETP shim for Google Publisher Tags
Categories
(Core :: Privacy: Anti-Tracking, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox91 | --- | fixed |
People
(Reporter: twisniewski, Assigned: twisniewski)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Google Publisher Tags normally participates in placing ads and other content, and our shim does not currently handle this use-case. We can avoid site breakage and add placeholders for content if the shim mimics this capability, as well as stubbing out the API more completely. This will enable fixes for quite a few sites. This will also allow us to make shims for other Google and third-party trackers which rely on or interact with Publisher Tags.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
- expand the API surface that is stubbed out more completely to account for sites relying on deprecated or more obscure functionality.
- have the shim perform basic content placement as some sites expect GPT to do.
Updated•3 years ago
|
Comment 3•3 years ago
|
||
bugherder |
The function removeEventListener
of pubads
is missing and throwing error. Can we also shim that function. Thanks.
Assignee | ||
Comment 5•2 years ago
|
||
@mortyccp, definitely. I will file a new bug for that ASAP. Do you have a link you can share where it is failing? I'd like to make sure my fix works well on an actual page, as sometimes the obvious fix isn't enough.
Sorry, the website that is failing is my internal web application. I can share the code that's causing the error. It's just very straightforward usage.
useEffect(() => {
const listener = event => { ... };
googletag.cmd.push(() => {
googletag.pubads().addEventListener("slotRenderEnded", listener);
});
return () => {
googletag.cmd.push(() => {
googletag.pubads().removeEventListener("slotRenderEnded", listener);
});
};
}, []);
Description
•