Move some methods/nested classes of `EditorBase` to `HTMLEditor`
Categories
(Core :: DOM: Editor, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox91 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
Some methods and nested classes of EditorBase
are not used by TextEditor
. So, we can move them to HTMLEditor
.
Assignee | ||
Comment 1•3 years ago
|
||
Assignee | ||
Comment 2•3 years ago
|
||
Unfortunately, marking its constructor and destructor as MOZ_CAN_RUN_SCRIPT
,
Maybe<AutoSelectionRestorer>::reset()
and
Maybe<AutoSelectionRestorer>::emplace()
cause bustage. Therefore, this patch
just mark them as MOZ_CAN_RUN_SCRIPT_BOUNDARY
.
Note that EditorBase::SavedSelectionRef()
cannot be moved to HTMLEditor
because mEditActionData
is a private member of EditorBase
.
Depends on D119001
Assignee | ||
Comment 3•3 years ago
|
||
I guess that this class is replaced with AutoPlaceholderBatch
, and both of
them are followed by its instances. However, I don't want to change the
behavior in this bug. Therefore, this patch just moves it into HTMLEditor
.
Depends on D119002
Assignee | ||
Comment 4•3 years ago
|
||
Depends on D119003
Comment 6•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f32e7018fa64
https://hg.mozilla.org/mozilla-central/rev/71b725af1aba
https://hg.mozilla.org/mozilla-central/rev/c118124ce70e
https://hg.mozilla.org/mozilla-central/rev/c471c8c0a12a
Description
•