Closed Bug 1719367 Opened 3 years ago Closed 3 years ago

[Bug] white flash appears on loading web page when activating gfx.webrender.software

Categories

(Core :: Graphics: WebRender, defect)

Unspecified
Android
defect

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: kbrosnan, Assigned: jnicol)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

From github: https://github.com/mozilla-mobile/fenix/issues/20193.

Steps to reproduce

set gfx.webrender.software to true and restart your browser. now try to open any website

Expected behavior

the background color when loading the page should be dark

Actual behavior

white flash appear

Device information

  • Device vendor / model and Android version: Samsung/Android 11
  • Firefox for Android version: Nightly v.91

Change performed by the Move to Bugzilla add-on.

I

Assignee: nobody → sotaro.ikeda.g

Fenix makes use of the default clear color by setting it to a dark
color when the dark theme is enabled to avoid white flashes while
pages are loading. In bug 1663732 we hooked this functionality up to
webrender, however, it was only used by the draw compositor. Now with
software webrender on Android, we sometimes use
RenderCompositorLayersSWGL rather than the draw compositor, and users
are therefore experiencing white flashes during page loads.

This adds a clear_color argument to StartCompositing(), which
RenderCompositorLayersSWGL uses to set the CompositorOGL's clear
color. This patch also makes Renderer::clear_color not an Option
type, as we only ever used it in Some form, and that simplifies the
FFI.

Sorry, Sotaro. I started working on this bug this morning but forgot to assign it to myself. I only noticed you had assigned it to yourself after I uploaded the patch!

No problem:) Thank for taking the bug.

Assignee: sotaro.ikeda.g → jnicol
Pushed by jnicol@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b5ad7d43bc54 Hook up default clear color to RenderCompositorLayersSWGL. r=sotaro
Flags: needinfo?(jnicol)

Oh, whoops. I forgot to update the examples for changing the Option<ColorF> to ColorF

Flags: needinfo?(jnicol)
Pushed by jnicol@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4054c870a437 Hook up default clear color to RenderCompositorLayersSWGL. r=sotaro
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: