Closed Bug 1719897 Opened 3 years ago Closed 3 years ago

Clicking the download button in pdf.js shouldn't duplicate files that are already on disk

Categories

(Firefox :: Downloads Panel, defect, P3)

Product:
Firefox
Component:
Downloads Panel
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: mtigley, Unassigned)

References

Details

(Whiteboard: [fidefe-Outreachy2021])

Steps to Reproduce

  1. Ensure browser.download.improvements_to_download_panel pref is set to true.
  2. Ensure "Save files to <path>" option is selected from about:preferences and that PDFs are configured to open in Firefox
  3. Try opening a PDF that sends CD: attachment. (eg. open any google doc and use File > Print inside the gdocs UI)
  4. Click the "Download" button displayed in pdf.js on the new tab that's been opened.

Expected Results
Another copy of the PDF is created on local disk and another tab opens showing the new file

Actual Results
We should either directly prompt where to save the PDF, or just hide the "Download" button for that file. If they decide to save the file again, we shouldn't be opening another tab and should just show the downloads panel.

Severity: -- → S3
Priority: -- → P3
Whiteboard: [fidefe-Outreachy2021]
Severity: S3 → S2
Severity: S2 → S3
Summary: Clicking the download button in pdf.s shouldn't duplicate files that are already on disk → Clicking the download button in pdf.js shouldn't duplicate files that are already on disk

(Downgrading this to S3 because 1740135 better captures the thing we think is S2 here, and fixing that bug will probably fix this bug.)

This is fixed now, after bug 1740135, though I found a fun edgecase over in bug 1750042... I'll try to dig in and file a new bug when I've figured that out.

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox97: --- → fixed
OS: Unspecified → All
Hardware: Unspecified → Desktop
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.