Dark Theme color problem for event description
Categories
(Calendar :: Dialogs, defect)
Tracking
(thunderbird91? verified)
People
(Reporter: adrien.rybarczyk, Assigned: Paenglab)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 1 obsolete file)
|
(deleted),
image/png
|
Details | |
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
darktrojan
:
review+
wsmwk
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
firstUpdateDescription.PNG
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36
Steps to reproduce:
- Be in dark theme or in system theme with dark application mode.
- Create an event and put a description.
Actual results:
The color of the description text is not adapted according to the theme for the first edition of the description.
If we save and reopen the event, the text color will be adapted according to the theme.
Expected results:
The color of the description text is at all times adapted to the theme.
|
Reporter | |
Comment 1•3 years ago
|
||
|
|
Reporter | |
Comment 2•3 years ago
|
||
|
|
Reporter | |
Updated•3 years ago
|
|
|
Reporter | |
Comment 3•3 years ago
|
||
The problem did not exist in 78. This seems to be due to the change of the textarea for an editor.
|
||
Updated•3 years ago
|
|
Assignee | |
Comment 4•3 years ago
|
||
The stylesheet was only loaded when there was a existing description. I moved it out of the if (aItem.descriptionText) {}.
Is this okay like this?
|
||
Comment 5•3 years ago
|
||
Comment on attachment 9233309 [details] [diff] [review]
1722472-load-EditorContent.css.patch
That triggers the save prompt even if no modifications are made. I moved editor.resetModificationCount(); below the conditional block and that seems to work.
|
|
Assignee | |
Comment 6•3 years ago
|
||
(In reply to Geoff Lankow (:darktrojan) from comment #5)
Comment on attachment 9233309 [details] [diff] [review]
1722472-load-EditorContent.css.patchThat triggers the save prompt even if no modifications are made. I moved
editor.resetModificationCount();below the conditional block and that seems to work.
Like this?
|
|
||
Comment 7•3 years ago
|
||
Comment on attachment 9233470 [details] [diff] [review]
1722472-load-EditorContent.css.patch
Like this.
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/3be537f2b12f
Load EditorContent.css always into the event description. r=darktrojan
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 9•3 years ago
|
||
Comment on attachment 9233470 [details] [diff] [review]
1722472-load-EditorContent.css.patch
[Approval Request Comment]
User impact if declined: with dark theme opening a new event the description isn't readable
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low
|
|
||
Comment 10•3 years ago
|
||
Comment on attachment 9233470 [details] [diff] [review]
1722472-load-EditorContent.css.patch
[Triage Comment]
Approved for beta
|
||
Comment 11•3 years ago
|
||
| bugherder uplift | ||
Thunderbird 91.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/0a12973eabe9
|
||
Comment 12•3 years ago
|
||
Verified using TB 91.0b5 on Fedora 34 Workstation, Gnome desktop.
Description
•