SessionStore C++ code should not try to load non-existing browser/ code when it isn't available
Categories
(Firefox :: Session Restore, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox92 | --- | fixed |
People
(Reporter: Gijs, Assigned: u608768)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
On Android, we repeatedly (I think once per process or something? I'm hoping it's not once per call...) hit NS_ERROR_FILE_NOT_FOUND for the imports from https://searchfox.org/mozilla-central/source/toolkit/components/sessionstore/SessionStoreFunctions.jsm that try to load the browser SessionStore.jsm .
I'm also a bit confused why this thin wrapper exists - couldn't SessionStore.jsm implement the XPCOM interface here directly, with the C++ code treating this as a "service" in the XPCOM sense? Or does that not work for some reason?
Either way, ISTM we could ifdef the code in C++ that tries to request these JSMs based on MOZ_BUILD_APP_IS_BROWSER or similar, or do a similar thing in JS if that were preferred for some reason.
|
Reporter | |
Updated•3 years ago
|
This is a browser-only module, and loading it for storage flushes causes errors
in GeckoView.
|
||
Updated•3 years ago
|
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Description
•