This issue is for identifying test failures when the browser.download.improvements_to_download_panel pref is true.

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mtigley, could you have a look please?
For more information, please visit auto_nag documentation.

I'm not sure why this hasn't landed, I'll let Micah answer this when she's back from PTO.

This patch hasn't landed yet since the test needs to be adjusted to cleanup any created .part files.

Backed out for causing failures on browser_download_overwrite.js. CLOSED TREE
Backout link : https://hg.mozilla.org/integration/autoland/rev/f8b4a8e59e4e0e2f1b38a8535f9af44279af363f
Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=CikCToF7RbGNH2sZa7pulw.0&resultStatus=success%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Cmochitests%2Cwith%2Csoftware%2Cwebrender%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-mochitest-browser-chrome-swr-e10s%2Cbc1&revision=75a253b872d49bc6a43fef3862e399861c0e184e
Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=351489228&repo=autoland&lineNumber=2791

(In reply to Cristina Cozmuta (:CrissCozmuta) from comment #11)

Backed out for causing failures on browser_download_overwrite.js. CLOSED TREE
Backout link : https://hg.mozilla.org/integration/autoland/rev/f8b4a8e59e4e0e2f1b38a8535f9af44279af363f
Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=CikCToF7RbGNH2sZa7pulw.0&resultStatus=success%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Cmochitests%2Cwith%2Csoftware%2Cwebrender%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-mochitest-browser-chrome-swr-e10s%2Cbc1&revision=75a253b872d49bc6a43fef3862e399861c0e184e
Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=351489228&repo=autoland&lineNumber=2791

It looks like the failures are related to just browser_download_overwrite.js. It seems to only happen on Linux 18.04 with WebRender enabled...which I'm not sure why yet.

In the meantime, I'll go ahead and land the first part of this patch queue.

https://hg.mozilla.org/mozilla-central/rev/48fac2760660

https://hg.mozilla.org/mozilla-central/rev/407b3b199382

https://hg.mozilla.org/mozilla-central/rev/033836060d50

Backed out 0b69342ce707 for failures on browser_test_data_text_csv

• backout: https://hg.mozilla.org/integration/autoland/rev/fe7fd9b31da5356183e5e45c0b20a686c821db86

• push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=NZbUdyP1SHq1cUOElWHwiw.0&revision=0b69342ce7070c4eb2b2445e1414819947cc973f&group_state=expanded

• tier 1 failure appeared on a subsequent push

• failure log: https://treeherder.mozilla.org/logviewer?job_id=352168160&repo=autoland&lineNumber=3887

[task 2021-09-20T23:32:31.275Z] 23:32:31     INFO - TEST-PASS | dom/security/test/general/browser_test_data_text_csv.js | file name of download should match - 
[task 2021-09-20T23:32:31.275Z] 23:32:31     INFO - Leaving test bound test_with_downloads_improvement_pref_disabled
[task 2021-09-20T23:32:31.276Z] 23:32:31     INFO - Entering test bound test_with_downloads_improvement_pref_enabled
[task 2021-09-20T23:32:31.276Z] 23:32:31     INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.com/browser/dom/security/test/general/file_data_text_csv.html" line: 0}]
[task 2021-09-20T23:32:31.277Z] 23:32:31     INFO - Buffered messages finished
[task 2021-09-20T23:32:31.278Z] 23:32:31     INFO - TEST-UNEXPECTED-FAIL | dom/security/test/general/browser_test_data_text_csv.js | Test timed out - 
[task 2021-09-20T23:32:31.279Z] 23:32:31     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-09-20T23:32:31.279Z] 23:32:31     INFO - TEST-UNEXPECTED-FAIL | dom/security/test/general/browser_test_data_text_csv.js | Uncaught exception received from previously timed out test - popupshown listener on #downloadsPanel not removed before the end of test
[task 2021-09-20T23:32:31.279Z] 23:32:31     INFO - GECKO(2628) | MEMORY STAT | vsize 3052MB | residentFast 318MB | heapAllocated 191MB
[task 2021-09-20T23:32:31.279Z] 23:32:31     INFO - TEST-OK | dom/security/test/general/browser_test_data_text_csv.js | took 45009ms

https://hg.mozilla.org/mozilla-central/rev/8c5fe2e40cc5
https://hg.mozilla.org/mozilla-central/rev/d60211f20840

(In reply to Natalia Csoregi [:nataliaCs] from comment #24)

Backed out 0b69342ce707 for failures on browser_test_data_text_csv

• backout: https://hg.mozilla.org/integration/autoland/rev/fe7fd9b31da5356183e5e45c0b20a686c821db86

• push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=NZbUdyP1SHq1cUOElWHwiw.0&revision=0b69342ce7070c4eb2b2445e1414819947cc973f&group_state=expanded

• tier 1 failure appeared on a subsequent push

• failure log: https://treeherder.mozilla.org/logviewer?job_id=352168160&repo=autoland&lineNumber=3887

I suspect we're not cleaning up properly in the previous test dom\security\test\general\browser_test_data_download.js. I've checked out a recent pull from central with this patch applied and it looks like we're getting a new failure when running the whole test directory:

dom/security/test/general/browser_test_data_download.js
  FAIL Uncaught exception - at chrome://mochitests/content/browser/dom/security/test/general/browser_test_data_download.js:108 - TypeError: can't access property Symbol.iterator, downloads._downloads is undefined
Stack trace:
test_with_downloads_pref_enabled@chrome://mochitests/content/browser/dom/security/test/general/browser_test_data_download.js:108:20
dom/security/test/general/browser_test_data_text_csv.js
  FAIL File contentType should be correct. - Got "text/html", expected "text/csv"
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1364
chrome://mochitests/content/browser/dom/security/test/general/browser_test_data_text_csv.js:test_with_downloads_improvement_pref_enabled:81
  FAIL File name should be correct. - Got "data:text/html,<body>data download</body>", expected "data:text/csv;foo,bar,foobar"
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1364
chrome://mochitests/content/browser/dom/security/test/general/browser_test_data_text_csv.js:test_with_downloads_improvement_pref_enabled:82

https://hg.mozilla.org/mozilla-central/rev/56a4ee0d1065

• Adjust the test's assertions to expect the download panel to open and a new download entry to be created when the browser.download.improvements_to_download_panel pref is true

https://hg.mozilla.org/mozilla-central/rev/d3a2b6bd72bf

https://hg.mozilla.org/mozilla-central/rev/f5bea658ee57
https://hg.mozilla.org/mozilla-central/rev/64bededdaf4c

https://hg.mozilla.org/mozilla-central/rev/06dda9072cb7

https://hg.mozilla.org/mozilla-central/rev/7fda24646bde

https://hg.mozilla.org/mozilla-central/rev/b4f47908b25b

https://hg.mozilla.org/mozilla-central/rev/6b47aa1f2d1c

https://hg.mozilla.org/mozilla-central/rev/d26d995c4c97

We're done! 🎉