Closed Bug 1730148 Opened 3 years ago Closed 3 years ago

Use onTargetAvailable/onTargetDestroyed to build the iframe pickers list instead of the frameUpdate event

Categories

(DevTools :: Framework, task)

Product:
DevTools
Component:
Framework
Type:
task

Tracking

(firefox96 fixed)

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox96 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

(Whiteboard: dt-perf-stability-mvp )

Attachments

(3 files, 1 obsolete file)

Bug 1730148 - [devtools] Add a `onSelect` argument to `targetCommand.watchTargets` . r=ochameau.
(deleted), text/x-phabricator-request
Details
Bug 1730148 - [devtools] Use targetCommand to populate iframe picker when EFT is enabled. r=ochameau.
(deleted), text/x-phabricator-request
Details
Bug 1730148 - [devtools] Handle onTargetSelected in DOM panel. r=ochameau.
(deleted), text/x-phabricator-request
Details

Once Bug 1685500 is done, we'll have targets for each documents we should show in the iframe picker list, so we should be able to only rely on the target watcher instead of the frameUpdate event we're using now

Blocks: 1731740
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Blocks: 1738915

The iframe picker code is refactored a bit so it's easier to follow.
This patch makes it so we support both EFT and non EFT scenarios.

Depends on D130175

Attachment #9248881 - Attachment description: Bug 1730148 - [devtools] Use targetCommand to populate iframe picker when EFT is enabled. r=ochameau. → Bug 1730148 - [devtools] Implement focusing on a specific target when EFT is enabled. r=ochameau.
Blocks: 1739061
Attachment #9248881 - Attachment description: Bug 1730148 - [devtools] Implement focusing on a specific target when EFT is enabled. r=ochameau. → WIP: Bug 1730148 - [devtools] Implement focusing on a specific target when EFT is enabled. r=ochameau.
Attachment #9248881 - Attachment description: WIP: Bug 1730148 - [devtools] Implement focusing on a specific target when EFT is enabled. r=ochameau. → Bug 1730148 - [devtools] Implement focusing on a specific target when EFT is enabled. r=ochameau.
Attachment #9248881 - Attachment description: Bug 1730148 - [devtools] Implement focusing on a specific target when EFT is enabled. r=ochameau. → Bug 1730148 - [devtools] Add a `onSelect` argument to `targetCommand.watchTargets` . r=ochameau.
Attachment #9249175 - Attachment description: Bug 1730148 - [devtools] Handle target focusing in DOM panel. r=ochameau. → Bug 1730148 - [devtools] Handle onTargetSelected in DOM panel. r=ochameau.
Blocks: 1740453
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a0e706688adc [devtools] Use targetCommand to populate iframe picker when EFT is enabled. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/819078e24fa6 [devtools] Add a `onSelect` argument to `targetCommand.watchTargets` . r=ochameau. https://hg.mozilla.org/integration/autoland/rev/9bd72db885eb [devtools] Handle onTargetSelected in DOM panel. r=ochameau.

Backed out for causing mochitest failures on browser_resources_document_events.js

Flags: needinfo?(nchevobbe)

Comment on attachment 9249711 [details]
Bug 1730148 - [devtools] Handle onTargetSelected in accessibility panel. r=ochameau.

Revision D130611 was moved to bug 1740453. Setting attachment 9249711 [details] to obsolete.

Attachment #9249711 - Attachment is obsolete: true
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ad17653a4658 [devtools] Use targetCommand to populate iframe picker when EFT is enabled. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/285c6dd1bde8 [devtools] Add a `onSelect` argument to `targetCommand.watchTargets` . r=ochameau. https://hg.mozilla.org/integration/autoland/rev/8b8b731d4ac4 [devtools] Handle onTargetSelected in DOM panel. r=ochameau.

https://hg.mozilla.org/mozilla-central/rev/ad17653a4658
https://hg.mozilla.org/mozilla-central/rev/285c6dd1bde8
https://hg.mozilla.org/mozilla-central/rev/8b8b731d4ac4

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: